You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by ho...@apache.org on 2024/02/21 17:22:14 UTC
(iceberg-python) branch main updated: docstring: Fix missing commit (#432)
This is an automated email from the ASF dual-hosted git repository.
honahx pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg-python.git
The following commit(s) were added to refs/heads/main by this push:
new 44948cd docstring: Fix missing commit (#432)
44948cd is described below
commit 44948cd9bab78b509b6befc960b5f248b37f53fe
Author: Fokko Driesprong <fo...@tabular.io>
AuthorDate: Wed Feb 21 18:22:07 2024 +0100
docstring: Fix missing commit (#432)
---
pyiceberg/catalog/__init__.py | 2 ++
pyiceberg/catalog/dynamodb.py | 1 +
pyiceberg/catalog/glue.py | 2 +-
pyiceberg/catalog/hive.py | 1 +
pyiceberg/catalog/rest.py | 2 ++
pyiceberg/catalog/sql.py | 2 +-
6 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/pyiceberg/catalog/__init__.py b/pyiceberg/catalog/__init__.py
index f7e34ab..db83658 100644
--- a/pyiceberg/catalog/__init__.py
+++ b/pyiceberg/catalog/__init__.py
@@ -413,6 +413,8 @@ class Catalog(ABC):
Raises:
NoSuchTableError: If a table with the given identifier does not exist.
+ CommitFailedException: Requirement not met, or a conflict with a concurrent commit.
+ CommitStateUnknownException: Failed due to an internal exception on the side of the catalog.
"""
@abstractmethod
diff --git a/pyiceberg/catalog/dynamodb.py b/pyiceberg/catalog/dynamodb.py
index d5f3b5e..b7b0f3d 100644
--- a/pyiceberg/catalog/dynamodb.py
+++ b/pyiceberg/catalog/dynamodb.py
@@ -208,6 +208,7 @@ class DynamoDbCatalog(Catalog):
Raises:
NoSuchTableError: If a table with the given identifier does not exist.
+ CommitFailedException: Requirement not met, or a conflict with a concurrent commit.
"""
raise NotImplementedError
diff --git a/pyiceberg/catalog/glue.py b/pyiceberg/catalog/glue.py
index 06484cb..089a30b 100644
--- a/pyiceberg/catalog/glue.py
+++ b/pyiceberg/catalog/glue.py
@@ -404,7 +404,7 @@ class GlueCatalog(Catalog):
Raises:
NoSuchTableError: If a table with the given identifier does not exist.
- CommitFailedException: If the commit failed.
+ CommitFailedException: Requirement not met, or a conflict with a concurrent commit.
"""
identifier_tuple = self.identifier_to_tuple_without_catalog(
tuple(table_request.identifier.namespace.root + [table_request.identifier.name])
diff --git a/pyiceberg/catalog/hive.py b/pyiceberg/catalog/hive.py
index aba3c17..4d4370f 100644
--- a/pyiceberg/catalog/hive.py
+++ b/pyiceberg/catalog/hive.py
@@ -360,6 +360,7 @@ class HiveCatalog(Catalog):
Raises:
NoSuchTableError: If a table with the given identifier does not exist.
+ CommitFailedException: Requirement not met, or a conflict with a concurrent commit.
"""
identifier_tuple = self.identifier_to_tuple_without_catalog(
tuple(table_request.identifier.namespace.root + [table_request.identifier.name])
diff --git a/pyiceberg/catalog/rest.py b/pyiceberg/catalog/rest.py
index e597b91..c824e69 100644
--- a/pyiceberg/catalog/rest.py
+++ b/pyiceberg/catalog/rest.py
@@ -596,6 +596,8 @@ class RestCatalog(Catalog):
Raises:
NoSuchTableError: If a table with the given identifier does not exist.
+ CommitFailedException: Requirement not met, or a conflict with a concurrent commit.
+ CommitStateUnknownException: Failed due to an internal exception on the side of the catalog.
"""
response = self._session.post(
self.url(Endpoints.update_table, prefixed=True, **self._split_identifier_for_path(table_request.identifier)),
diff --git a/pyiceberg/catalog/sql.py b/pyiceberg/catalog/sql.py
index 62a2dac..0059da6 100644
--- a/pyiceberg/catalog/sql.py
+++ b/pyiceberg/catalog/sql.py
@@ -373,7 +373,7 @@ class SqlCatalog(Catalog):
Raises:
NoSuchTableError: If a table with the given identifier does not exist.
- CommitFailedException: If the commit failed.
+ CommitFailedException: Requirement not met, or a conflict with a concurrent commit.
"""
identifier_tuple = self.identifier_to_tuple_without_catalog(
tuple(table_request.identifier.namespace.root + [table_request.identifier.name])