[GitHub] [spark] cloud-fan commented on a change in pull request #31316: [SPARK-33599][SQL][FOLLOWUP] Group exception messages in catalyst/analysis

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #31316:
URL: https://github.com/apache/spark/pull/31316#discussion_r570987268



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
##########
@@ -35,7 +35,8 @@ import org.apache.spark.sql.util.CaseInsensitiveStringMap
  * resolved.
  */
 class UnresolvedException[TreeType <: TreeNode[_]](tree: TreeType, function: String)
-  extends TreeNodeException(tree, s"Invalid call to $function on unresolved object", null)
+  extends TreeNodeException(
+    tree, QueryCompilationErrors.invalidCallFunctionOnUnresolvedObjectError(function), null)

Review comment:
       are we throwing an exception in the constructor?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org