[jira] [Commented] (GEODE-5863) CqDataDUnitTest.testMultipleExecuteWithInitialResults ignores assertion failures

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656058#comment-16656058 ] 

ASF subversion and git services commented on GEODE-5863:
--------------------------------------------------------

Commit 61014b2f20f4e57e59bb2ffe2e9968545ba0e37a in geode's branch refs/heads/develop from Dan Smith
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=61014b2 ]

GEODE-5863: Ingoring testMultipleExecuteWithInitialResults

This test fails after increasing the Awaitility timeout. However, it
previously was not testing anything because it hit the (smaller)
awailitity timeout but ignored the timeout exception.

Ignoring this test until we actually rework this into a valid test.

Co-Authored-By "Ken Howe" <kh...@pivotal.io>


> CqDataDUnitTest.testMultipleExecuteWithInitialResults ignores assertion failures
> --------------------------------------------------------------------------------
>
>                 Key: GEODE-5863
>                 URL: https://issues.apache.org/jira/browse/GEODE-5863
>             Project: Geode
>          Issue Type: Improvement
>            Reporter: Dan Smith
>            Priority: Major
>              Labels: swat
>
> This test has assertions in an asynchronous thread. However, it never actually checks the results from that thread, it just asserts that the thread finishes. In practice, processCqs always throws an Awaitility exception, which is ignored and the test passes.
> This is the problematic code. ThreadUtils.join does not check the result of the async invocation:
> {code}
> ThreadUtils.join(processCqs, 60 * 1000);
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)