[GitHub] [trafficcontrol] rob05c commented on a change in pull request #3689: Fix TO update_status to exclude ADMIN_DOWN

[GitBox <gi...@apache.org>]

rob05c commented on a change in pull request #3689: Fix TO update_status to exclude ADMIN_DOWN
URL: https://github.com/apache/trafficcontrol/pull/3689#discussion_r295936105
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/server/servers_update_status.go
 ##########
 @@ -49,7 +49,7 @@ func getServerUpdateStatus(tx *sql.Tx, cfg *config.Config, hostName string) ([]t
 	baseSelectStatement :=
 		`WITH parentservers AS (SELECT ps.id, ps.cachegroup, ps.cdn_id, ps.upd_pending, ps.reval_pending FROM server ps
          LEFT JOIN status AS pstatus ON pstatus.id = ps.status
-         WHERE pstatus.name != 'OFFLINE' ),
+         WHERE (pstatus.name = '` + string(tc.CacheStatusOnline) + `' OR pstatus.name = '` + string(tc.CacheStatusReported) + `') ),
 
 Review comment:
   You're right, the ideal solution would handle that. But the alternative is Edges never being able to finish a Reval, if any Mid is ADMIN_DOWN and not running ORT. Until we can get the ideal solution in place, this seems like the less bad option.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services