You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/07/17 23:32:04 UTC
[GitHub] [incubator-mxnet] anirudhacharya commented on a change in pull
request #15560: Add fp16 support for topk
anirudhacharya commented on a change in pull request #15560: Add fp16 support for topk
URL: https://github.com/apache/incubator-mxnet/pull/15560#discussion_r304683317
##########
File path: src/operator/tensor/ordering_op-inl.h
##########
@@ -420,8 +420,6 @@ void TopKImpl(const RunContext &ctx,
mxnet::op::SortByKeyWorkspaceSize<int, int, xpu>(src.Size()));
temp_size = std::max(temp_size,
mxnet::op::SortByKeyWorkspaceSize<int, DType, xpu>(src.Size()));
- temp_size = std::max(temp_size,
Review comment:
there was this - https://github.com/apache/incubator-mxnet/pull/14912#pullrequestreview-237632437 concern here by @sxjscience
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services