You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by shen guoquan <gu...@intel.com> on 2014/09/25 08:30:01 UTC
Re: Review Request 25811: SENTRY-405:Adding a general jdo access
layer(sentrystore) to support the new authorization model
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25811/
-----------------------------------------------------------
(Updated 九月 25, 2014, 6:29 a.m.)
Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
Changes
-------
changes according to internal sentry member comments
Repository: sentry
Description
-------
Currently the sentryStore in Sentry only supports database structure authorize model such as Hive/Impala, in order to support more components like Solr or other no database authorization
model component. It needs to create a general store to communicate with outside, the structure of privilege model should be hidden. The general store uses interface to transfer the needed information of privilege
Diffs (updated)
-----
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Action.java 44b7b2b
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/ActionReader.java PRE-CREATION
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/BaseAction.java PRE-CREATION
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/CompoundAction.java PRE-CREATION
sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/Field.java PRE-CREATION
sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchAction.java PRE-CREATION
sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchActionReader.java PRE-CREATION
sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchModelAuthorizable.java 4526c4e
sentry-core/sentry-core-model-search/src/test/java/org/apache/sentry/core/search/TestSearchAction.java PRE-CREATION
sentry-provider/sentry-provider-db/pom.xml b4167e4
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/persistent/GMPrivilegeSentryStore.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/persistent/SentryStoreBase.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/persistent/SentryStoreLayer.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/PrivilegeObject.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/PrivilegeUtil.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/genericModel/service/persistent/SentryStoreIntegrationBase.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/genericModel/service/persistent/TestRoleAndGroupSentryStore.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/genericModel/service/persistent/TestSearchPrivilegeSentryStore.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/genericModel/service/thrift/TestPrivilegeUtils.java PRE-CREATION
Diff: https://reviews.apache.org/r/25811/diff/
Testing
-------
Thanks,
shen guoquan
Re: Review Request 25811: SENTRY-405:Adding a general jdo access
layer(sentrystore) to support the new authorization model
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25811/
-----------------------------------------------------------
(Updated 十二月 17, 2014, 8:32 a.m.)
Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
Repository: sentry
Description
-------
Currently the sentryStore in Sentry only supports database structure authorize model such as Hive/Impala, in order to support more components like Solr or other no database authorization
model component. It needs to create a general store to communicate with outside, the structure of privilege model should be hidden. The general store uses interface to transfer the needed information of privilege
Diffs (updated)
-----
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Action.java 44b7b2b
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/BitFieldAction.java PRE-CREATION
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/BitFieldActionFactory.java PRE-CREATION
sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/Field.java PRE-CREATION
sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchActionFactory.java PRE-CREATION
sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchModelAuthorizable.java 4526c4e
sentry-core/sentry-core-model-search/src/test/java/org/apache/sentry/core/search/TestSearchBitFieldAction.java PRE-CREATION
sentry-provider/sentry-provider-db/pom.xml 82e4042
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeObject.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java f98e853
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreIntegrationBase.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestDelegateSentryStore.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestPrivilegeOperatePersistence.java PRE-CREATION
Diff: https://reviews.apache.org/r/25811/diff/
Testing
-------
Thanks,
shen guoquan
Re: Review Request 25811: SENTRY-405:Adding a general jdo access
layer(sentrystore) to support the new authorization model
Posted by shen guoquan <gu...@intel.com>.
> On 十二月 15, 2014, 12:09 a.m., Arun Suresh wrote:
> > Thanks for working on this Guoquan,
> >
> > The patch looks good overall..
> >
> > My only comment probably is the whole ACTION framework (Compound and Basic action)
> > I understand this is possibly the only way we can deal with this in the short run... But is it possible for you to look into maybe refactoring this into a BitField ? That way adding and removing ACTIONS will be easier and you might not need a Reader/Writier
hi Arun, thanks for your review. Using the bitField is a good idea, I have finish refactor the source code and update the patch soon. Thanks very much.
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25811/#review65064
-----------------------------------------------------------
On 十二月 5, 2014, 2:40 p.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25811/
> -----------------------------------------------------------
>
> (Updated 十二月 5, 2014, 2:40 p.m.)
>
>
> Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Currently the sentryStore in Sentry only supports database structure authorize model such as Hive/Impala, in order to support more components like Solr or other no database authorization
> model component. It needs to create a general store to communicate with outside, the structure of privilege model should be hidden. The general store uses interface to transfer the needed information of privilege
>
>
> Diffs
> -----
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Action.java 44b7b2b
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/ActionReader.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/BasicAction.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/CompoundAction.java PRE-CREATION
> sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/Field.java PRE-CREATION
> sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchAction.java PRE-CREATION
> sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchActionReader.java PRE-CREATION
> sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchModelAuthorizable.java 4526c4e
> sentry-core/sentry-core-model-search/src/test/java/org/apache/sentry/core/search/TestSearchAction.java PRE-CREATION
> sentry-provider/sentry-provider-db/pom.xml 3c9d318
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeObject.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 7d2cb12
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreIntegrationBase.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestDelegateSentryStore.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestPrivilegeOperatePersistence.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25811/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 25811: SENTRY-405:Adding a general jdo access
layer(sentrystore) to support the new authorization model
Posted by Arun Suresh <ar...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25811/#review65064
-----------------------------------------------------------
Thanks for working on this Guoquan,
The patch looks good overall..
My only comment probably is the whole ACTION framework (Compound and Basic action)
I understand this is possibly the only way we can deal with this in the short run... But is it possible for you to look into maybe refactoring this into a BitField ? That way adding and removing ACTIONS will be easier and you might not need a Reader/Writier
- Arun Suresh
On Dec. 5, 2014, 2:40 p.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25811/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 2:40 p.m.)
>
>
> Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Currently the sentryStore in Sentry only supports database structure authorize model such as Hive/Impala, in order to support more components like Solr or other no database authorization
> model component. It needs to create a general store to communicate with outside, the structure of privilege model should be hidden. The general store uses interface to transfer the needed information of privilege
>
>
> Diffs
> -----
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Action.java 44b7b2b
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/ActionReader.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/BasicAction.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/CompoundAction.java PRE-CREATION
> sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/Field.java PRE-CREATION
> sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchAction.java PRE-CREATION
> sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchActionReader.java PRE-CREATION
> sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchModelAuthorizable.java 4526c4e
> sentry-core/sentry-core-model-search/src/test/java/org/apache/sentry/core/search/TestSearchAction.java PRE-CREATION
> sentry-provider/sentry-provider-db/pom.xml 3c9d318
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeObject.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 7d2cb12
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreIntegrationBase.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestDelegateSentryStore.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestPrivilegeOperatePersistence.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25811/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 25811: SENTRY-405:Adding a general jdo access
layer(sentrystore) to support the new authorization model
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25811/
-----------------------------------------------------------
(Updated 十二月 5, 2014, 2:40 p.m.)
Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
Repository: sentry
Description
-------
Currently the sentryStore in Sentry only supports database structure authorize model such as Hive/Impala, in order to support more components like Solr or other no database authorization
model component. It needs to create a general store to communicate with outside, the structure of privilege model should be hidden. The general store uses interface to transfer the needed information of privilege
Diffs (updated)
-----
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Action.java 44b7b2b
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/ActionReader.java PRE-CREATION
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/BasicAction.java PRE-CREATION
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/CompoundAction.java PRE-CREATION
sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/Field.java PRE-CREATION
sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchAction.java PRE-CREATION
sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchActionReader.java PRE-CREATION
sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchModelAuthorizable.java 4526c4e
sentry-core/sentry-core-model-search/src/test/java/org/apache/sentry/core/search/TestSearchAction.java PRE-CREATION
sentry-provider/sentry-provider-db/pom.xml 3c9d318
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeObject.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 7d2cb12
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreIntegrationBase.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestDelegateSentryStore.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestPrivilegeOperatePersistence.java PRE-CREATION
Diff: https://reviews.apache.org/r/25811/diff/
Testing
-------
Thanks,
shen guoquan
Re: Review Request 25811: SENTRY-405:Adding a general jdo access
layer(sentrystore) to support the new authorization model
Posted by shen guoquan <gu...@intel.com>.
> On 十二月 2, 2014, 11:56 p.m., Arun Suresh wrote:
> > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/BaseAction.java, line 19
> > <https://reviews.apache.org/r/25811/diff/2/?file=705112#file705112line19>
> >
> > If this a public class, maybe some comments to describe how this class is used...
> >
> > Else refactor into a private static inner class
Thanks for comments, i will fix it
> On 十二月 2, 2014, 11:56 p.m., Arun Suresh wrote:
> > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/CompoundAction.java, line 23
> > <https://reviews.apache.org/r/25811/diff/2/?file=705113#file705113line23>
> >
> > If this a public class, maybe some comments to describe how this class is used...
> >
> > Else refactor into a private static inner class
Thanks for comments, i will fix it
> On 十二月 2, 2014, 11:56 p.m., Arun Suresh wrote:
> > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/CompoundAction.java, line 41
> > <https://reviews.apache.org/r/25811/diff/2/?file=705113#file705113line41>
> >
> > can we give another name other than 'leftActions' ?
Thanks for comments, i will fix it
> On 十二月 2, 2014, 11:56 p.m., Arun Suresh wrote:
> > sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/Field.java, line 19
> > <https://reviews.apache.org/r/25811/diff/2/?file=705114#file705114line19>
> >
> > If this a public class, maybe some comments to describe how this class is used...
> >
> > Else refactor into a private static inner class
Hi Arun. Thanks for your comment. I think you give me a good direction about refactor the patch. Moving all operations that involve just role or group to a separate class, the operations related the generic privileges to another class. I refactor this patch, let the operations that involve role or group parts to reuse the existing code, then write a new privilege operator to process the other requests. I have already update that pacth, please help me review it and feel free give your comments. Thanks a lot
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25811/#review63610
-----------------------------------------------------------
On 十二月 5, 2014, 2:40 p.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25811/
> -----------------------------------------------------------
>
> (Updated 十二月 5, 2014, 2:40 p.m.)
>
>
> Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Currently the sentryStore in Sentry only supports database structure authorize model such as Hive/Impala, in order to support more components like Solr or other no database authorization
> model component. It needs to create a general store to communicate with outside, the structure of privilege model should be hidden. The general store uses interface to transfer the needed information of privilege
>
>
> Diffs
> -----
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Action.java 44b7b2b
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/ActionReader.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/BasicAction.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/CompoundAction.java PRE-CREATION
> sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/Field.java PRE-CREATION
> sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchAction.java PRE-CREATION
> sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchActionReader.java PRE-CREATION
> sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchModelAuthorizable.java 4526c4e
> sentry-core/sentry-core-model-search/src/test/java/org/apache/sentry/core/search/TestSearchAction.java PRE-CREATION
> sentry-provider/sentry-provider-db/pom.xml 3c9d318
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeObject.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 7d2cb12
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreIntegrationBase.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestDelegateSentryStore.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestPrivilegeOperatePersistence.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25811/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 25811: SENTRY-405:Adding a general jdo access
layer(sentrystore) to support the new authorization model
Posted by Arun Suresh <ar...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25811/#review63610
-----------------------------------------------------------
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/BaseAction.java
<https://reviews.apache.org/r/25811/#comment105889>
If this a public class, maybe some comments to describe how this class is used...
Else refactor into a private static inner class
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/CompoundAction.java
<https://reviews.apache.org/r/25811/#comment105890>
If this a public class, maybe some comments to describe how this class is used...
Else refactor into a private static inner class
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/CompoundAction.java
<https://reviews.apache.org/r/25811/#comment105892>
can we give another name other than 'leftActions' ?
sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/Field.java
<https://reviews.apache.org/r/25811/#comment105891>
If this a public class, maybe some comments to describe how this class is used...
Else refactor into a private static inner class
- Arun Suresh
On Sept. 25, 2014, 6:29 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25811/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2014, 6:29 a.m.)
>
>
> Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Currently the sentryStore in Sentry only supports database structure authorize model such as Hive/Impala, in order to support more components like Solr or other no database authorization
> model component. It needs to create a general store to communicate with outside, the structure of privilege model should be hidden. The general store uses interface to transfer the needed information of privilege
>
>
> Diffs
> -----
>
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Action.java 44b7b2b
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/ActionReader.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/BaseAction.java PRE-CREATION
> sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/CompoundAction.java PRE-CREATION
> sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/Field.java PRE-CREATION
> sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchAction.java PRE-CREATION
> sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchActionReader.java PRE-CREATION
> sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchModelAuthorizable.java 4526c4e
> sentry-core/sentry-core-model-search/src/test/java/org/apache/sentry/core/search/TestSearchAction.java PRE-CREATION
> sentry-provider/sentry-provider-db/pom.xml b4167e4
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/persistent/GMPrivilegeSentryStore.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/persistent/SentryStoreBase.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/persistent/SentryStoreLayer.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/PrivilegeObject.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/PrivilegeUtil.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/genericModel/service/persistent/SentryStoreIntegrationBase.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/genericModel/service/persistent/TestRoleAndGroupSentryStore.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/genericModel/service/persistent/TestSearchPrivilegeSentryStore.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/genericModel/service/thrift/TestPrivilegeUtils.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25811/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> shen guoquan
>
>