You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/21 00:17:42 UTC
[GitHub] [beam] nlu90 opened a new pull request, #22375: fix pulsar reader calls
nlu90 opened a new pull request, #22375:
URL: https://github.com/apache/beam/pull/22375
**Please** add a meaningful description for your change here
Fix the usages of Pulsar Reader API
1. `readNext` will block forever if no timeout provided
2. `hasReachedEndOfTopic` only apply to a "terminated" topic
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22375: fix pulsar reader calls
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22375:
URL: https://github.com/apache/beam/pull/22375#issuecomment-1198415831
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22375: fix pulsar reader calls
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22375:
URL: https://github.com/apache/beam/pull/22375#issuecomment-1198061327
Reminder, please take a look at this pr: @kennknowles @johnjcasey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22375: fix pulsar reader calls
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22375:
URL: https://github.com/apache/beam/pull/22375#issuecomment-1370888689
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix pulsar reader calls [beam]
Posted by "hpvd (via GitHub)" <gi...@apache.org>.
hpvd commented on PR #22375:
URL: https://github.com/apache/beam/pull/22375#issuecomment-2074761622
added this to [Parent issue] Support for Apache Pulsar #31078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #22375: fix pulsar reader calls
Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #22375:
URL: https://github.com/apache/beam/pull/22375#issuecomment-1198414674
R: @johnjcasey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22375: fix pulsar reader calls
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22375:
URL: https://github.com/apache/beam/pull/22375#issuecomment-1190913589
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @kennknowles for label java.
R: @johnjcasey for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on a diff in pull request #22375: fix pulsar reader calls
Posted by GitBox <gi...@apache.org>.
johnjcasey commented on code in PR #22375:
URL: https://github.com/apache/beam/pull/22375#discussion_r934558030
##########
sdks/java/io/pulsar/src/main/java/org/apache/beam/sdk/io/pulsar/ReadFromPulsarDoFn.java:
##########
@@ -155,11 +155,11 @@ public ProcessContinuation processElement(
reader.seek(startTimestamp);
}
while (true) {
- if (reader.hasReachedEndOfTopic()) {
+ if (!reader.hasMessageAvailable()) {
reader.close();
return ProcessContinuation.stop();
}
- Message<byte[]> message = reader.readNext();
+ Message<byte[]> message = reader.readNext(5, TimeUnit.SECONDS);
Review Comment:
why did you choose 5 seconds here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org