[GitHub] [hadoop] avijayanhwx commented on a change in pull request #868: HDDS-1568 : Add RocksDB metrics to OM.

[GitBox <gi...@apache.org>]

avijayanhwx commented on a change in pull request #868: HDDS-1568 : Add RocksDB metrics to OM.
URL: https://github.com/apache/hadoop/pull/868#discussion_r288731790
 
 

 ##########
 File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/RocksDBStoreMBean.java
 ##########
 @@ -41,13 +49,21 @@
 /**
  * Adapter JMX bean to publish all the Rocksdb metrics.
  */
-public class RocksDBStoreMBean implements DynamicMBean {
+public class RocksDBStoreMBean implements DynamicMBean, MetricsSource {
 
 
 Review comment:
   @anuengineer I verified by checking the /prom servlet end point. I also made changes in the prometheus sink metric name sanitization code so that the RocksDB metric names don't look odd. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org