You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@mynewt.apache.org by "piotrnarajowski (via GitHub)" <gi...@apache.org> on 2024/09/20 13:22:54 UTC
[PR] nimble/host: remove unnecessarry opcode check in ble_eatt_l2cap_event_fn [mynewt-nimble]
piotrnarajowski opened a new pull request, #1869:
URL: https://github.com/apache/mynewt-nimble/pull/1869
This check caused l2cap disconnection when opcode included in received data was write command which is supported and can be used on eatt. Also, the comment seemed irrelevant. Fixes GATT/SR/GAW/BV-01-C
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/host: remove unnecessarry opcode check in ble_eatt_l2cap_event_fn [mynewt-nimble]
Posted by "piotrnarajowski (via GitHub)" <gi...@apache.org>.
piotrnarajowski commented on PR #1869:
URL: https://github.com/apache/mynewt-nimble/pull/1869#issuecomment-2363729615
#AutoPTS run mynewt GATT/SR/GAW/BV-01-C
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/host: remove unnecessarry opcode check in ble_eatt_l2cap_event_fn [mynewt-nimble]
Posted by "piotrnarajowski (via GitHub)" <gi...@apache.org>.
piotrnarajowski commented on PR #1869:
URL: https://github.com/apache/mynewt-nimble/pull/1869#issuecomment-2363752694
#AutoPTS run mynewt GATT/SR --test_case_limit 10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/host: remove unnecessarry opcode check in ble_eatt_l2cap_event_fn [mynewt-nimble]
Posted by "piotrnarajowski (via GitHub)" <gi...@apache.org>.
piotrnarajowski commented on PR #1869:
URL: https://github.com/apache/mynewt-nimble/pull/1869#issuecomment-2363808799
FYI @KKopyscinski
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/host: remove unnecessarry opcode check in ble_eatt_l2cap_event_fn [mynewt-nimble]
Posted by "rymanluk (via GitHub)" <gi...@apache.org>.
rymanluk commented on code in PR #1869:
URL: https://github.com/apache/mynewt-nimble/pull/1869#discussion_r1770802154
##########
nimble/host/src/ble_eatt.c:
##########
@@ -268,16 +268,6 @@ ble_eatt_l2cap_event_fn(struct ble_l2cap_event *event, void *arg)
opcode = event->receive.sdu_rx->om_data[0];
if (ble_att_is_response_op(opcode)) {
ble_npl_eventq_put(ble_hs_evq_get(), &eatt->wakeup_ev);
- } else if (!ble_att_is_request_op(opcode)) {
- /* As per BLE 5.4 Standard, Vol. 3, Part F, section 5.3.2
Review Comment:
looks it was Part G.
Anyways, instead of this we should maybe extend both `ble_att_is_response_op` and `ble_att_is_request_op ` so it returns depends on EATT case and satisfy below
Vol 3, Part G, 4.2
If an ATT PDU is supported on any ATT bearer, then it shall be supported on all
supported ATT bearers with the following exceptions:
• The Exchange MTU sub-procedure shall only be supported on the LE Fixed Channel
Unenhanced ATT bearer.
• The Signed Write Without Response sub-procedure shall only be supported on the LE
Fixed Channel Unenhanced ATT bearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/host: remove unnecessarry opcode check in ble_eatt_l2cap_event_fn [mynewt-nimble]
Posted by "codecoup-tester (via GitHub)" <gi...@apache.org>.
codecoup-tester commented on PR #1869:
URL: https://github.com/apache/mynewt-nimble/pull/1869#issuecomment-2363756492
AutoPTS Bot results:
No failed test found.
<details><summary>Successful tests</summary>GATT GATT/SR/GAW/BV-01-C PASS</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/host: remove unnecessarry opcode check in ble_eatt_l2cap_event_fn [mynewt-nimble]
Posted by "codecoup-tester (via GitHub)" <gi...@apache.org>.
codecoup-tester commented on PR #1869:
URL: https://github.com/apache/mynewt-nimble/pull/1869#issuecomment-2363755912
Scheduled PR https://github.com/apache/mynewt-nimble/pull/1869#issuecomment-2363752694, board: nrf52, estimated start time: 15:37:02, test case count: 10, estimated duration: 0:06:42<details><summary>Test cases to be run</summary>GATT/SR/GAC/BV-01-C<br>GATT/SR/GAC/BI-01-C<br>GATT/SR/GAD/BV-01-C<br>GATT/SR/GAD/BV-02-C<br>GATT/SR/GAD/BV-03-C<br>GATT/SR/GAD/BV-04-C<br>GATT/SR/GAD/BV-05-C<br>GATT/SR/GAD/BV-06-C<br>GATT/SR/GAR/BV-01-C<br>GATT/SR/GAR/BI-01-C</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/host: remove unnecessarry opcode check in ble_eatt_l2cap_event_fn [mynewt-nimble]
Posted by "codecoup-tester (via GitHub)" <gi...@apache.org>.
codecoup-tester commented on PR #1869:
URL: https://github.com/apache/mynewt-nimble/pull/1869#issuecomment-2363730256
Scheduled PR https://github.com/apache/mynewt-nimble/pull/1869#issuecomment-2363729615, board: nrf52, estimated start time: 15:24:29, test case count: 1, estimated duration: 0:01:07<details><summary>Test cases to be run</summary>GATT/SR/GAW/BV-01-C</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/host: add eatt opcode check in ble_eatt_l2cap_event_fn [mynewt-nimble]
Posted by "rymanluk (via GitHub)" <gi...@apache.org>.
rymanluk merged PR #1869:
URL: https://github.com/apache/mynewt-nimble/pull/1869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/host: remove unnecessarry opcode check in ble_eatt_l2cap_event_fn [mynewt-nimble]
Posted by "codecoup-tester (via GitHub)" <gi...@apache.org>.
codecoup-tester commented on PR #1869:
URL: https://github.com/apache/mynewt-nimble/pull/1869#issuecomment-2363807494
AutoPTS Bot results:
No failed test found.
<details><summary>Successful tests</summary>GATT GATT/SR/GAC/BI-01-C PASS<br>GATT GATT/SR/GAC/BV-01-C PASS<br>GATT GATT/SR/GAD/BV-01-C PASS<br>GATT GATT/SR/GAD/BV-02-C PASS<br>GATT GATT/SR/GAD/BV-03-C PASS<br>GATT GATT/SR/GAD/BV-04-C PASS<br>GATT GATT/SR/GAD/BV-05-C PASS<br>GATT GATT/SR/GAD/BV-06-C PASS<br>GATT GATT/SR/GAR/BI-01-C PASS<br>GATT GATT/SR/GAR/BV-01-C PASS</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org