You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/10 14:33:57 UTC

[GitHub] [spark] WangGuangxin opened a new pull request, #37467: [SPARK-40035][SQL] Avoid apply filter twice when listing files

WangGuangxin opened a new pull request, #37467:
URL: https://github.com/apache/spark/pull/37467

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the guideline first in
        'core/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   Avoid apply filters multiple times on `nestedFiles`
   
   
   ### Why are the changes needed?
   Improve performance.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Mannually test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] WangGuangxin commented on pull request #37467: [SPARK-40035][SQL] Avoid apply filter twice when listing files

Posted by GitBox <gi...@apache.org>.
WangGuangxin commented on PR #37467:
URL: https://github.com/apache/spark/pull/37467#issuecomment-1213707771

   Yes, it's duplicate


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #37467: [SPARK-40035][SQL] Avoid apply filter twice when listing files

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #37467:
URL: https://github.com/apache/spark/pull/37467#issuecomment-1212764411

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] JoshRosen commented on pull request #37467: [SPARK-40035][SQL] Avoid apply filter twice when listing files

Posted by GitBox <gi...@apache.org>.
JoshRosen commented on PR #37467:
URL: https://github.com/apache/spark/pull/37467#issuecomment-1213430058

   (Drive-by comment / note to other reviewers): it looks like this PR and https://github.com/apache/spark/pull/37498 are aiming to solve the same problem (and thus are duplicates). We should pick a preferred approach and close one of the PRs / JIRAs as a duplicate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] WangGuangxin closed pull request #37467: [SPARK-40035][SQL] Avoid apply filter twice when listing files

Posted by GitBox <gi...@apache.org>.
WangGuangxin closed pull request #37467: [SPARK-40035][SQL] Avoid apply filter twice when listing files
URL: https://github.com/apache/spark/pull/37467


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org