You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/01/15 17:18:39 UTC

[GitHub] [zookeeper] ravowlga123 commented on a change in pull request #1220: ZOOKEEPER-2293 Log warning msg once by adding flag

ravowlga123 commented on a change in pull request #1220: ZOOKEEPER-2293 Log warning msg once by adding flag
URL: https://github.com/apache/zookeeper/pull/1220#discussion_r367002795
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
 ##########
 @@ -1348,15 +1348,19 @@ public void processConnectRequest(ServerCnxn cnxn, ByteBuffer incomingBuffer)
         ServerMetrics.getMetrics().CONNECTION_REQUEST_COUNT.add(1);
 
         boolean readOnly = false;
+        boolean logWarning = false;
 
 Review comment:
   Hey @eolivelli Thanks for your review. I have changed the variable name as per your suggestion. I didn't mean to declare variable as an instance field but do you think to declare it as an instance field makes more sense?? Please do let me know

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services