You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rajesh Battala <ra...@citrix.com> on 2013/07/04 14:32:48 UTC
Re: Review Request 12227: NPE while deploying any instances in kvm/vmware
using ZWPS due to capacityIops
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12227/
-----------------------------------------------------------
(Updated July 4, 2013, 12:32 p.m.)
Review request for cloudstack, edison su, Ram Ganesh, and Sateesh Chodapuneedi.
Changes
-------
uploaded the patch rebasing with 4.2 branch.
Summary (updated)
-----------------
NPE while deploying any instances in kvm/vmware using ZWPS due to capacityIops
Bugs: 3301
Repository: cloudstack-git
Description
-------
Issue:
When VM is getting deployed in ZWPS(kvm, vmware), NPE is occuring.
Fixed:
SolidFire storage had introduced iops, its setting capacityIops on the pool level. Only solidfire is setting and getting it which is causing NPE when checking this value for other type PS.
This fixed will resolve the issue for any storage provider which don't set capacityIops.
Diffs (updated)
-----
server/src/com/cloud/storage/StorageManagerImpl.java bb21afb
Diff: https://reviews.apache.org/r/12227/diff/
Testing
-------
1. Adding ZWPS, and deployed the VM in KVM. Vm got successfully deployed.
2. Adding CWPS and deployed the VM in KVM. VM got deployed successfully.
Thanks,
Rajesh Battala
Re: Review Request 12227: NPE while deploying any instances in kvm/vmware
using ZWPS due to capacityIops
Posted by Rajesh Battala <ra...@citrix.com>.
> On July 8, 2013, 7:16 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
> > Fix looks good.
Thanks for the review comments
- Rajesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12227/#review22846
-----------------------------------------------------------
On July 4, 2013, 12:32 p.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12227/
> -----------------------------------------------------------
>
> (Updated July 4, 2013, 12:32 p.m.)
>
>
> Review request for cloudstack, edison su, Ram Ganesh, and Sateesh Chodapuneedi.
>
>
> Bugs: 3301
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Issue:
> When VM is getting deployed in ZWPS(kvm, vmware), NPE is occuring.
>
> Fixed:
> SolidFire storage had introduced iops, its setting capacityIops on the pool level. Only solidfire is setting and getting it which is causing NPE when checking this value for other type PS.
> This fixed will resolve the issue for any storage provider which don't set capacityIops.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/StorageManagerImpl.java bb21afb
>
> Diff: https://reviews.apache.org/r/12227/diff/
>
>
> Testing
> -------
>
> 1. Adding ZWPS, and deployed the VM in KVM. Vm got successfully deployed.
> 2. Adding CWPS and deployed the VM in KVM. VM got deployed successfully.
>
>
> Thanks,
>
> Rajesh Battala
>
>
Re: Review Request 12227: NPE while deploying any instances in kvm/vmware
using ZWPS due to capacityIops
Posted by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12227/#review22846
-----------------------------------------------------------
Ship it!
Fix looks good.
- Venkata Siva Vijayendra Bhamidipati
On July 4, 2013, 12:32 p.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12227/
> -----------------------------------------------------------
>
> (Updated July 4, 2013, 12:32 p.m.)
>
>
> Review request for cloudstack, edison su, Ram Ganesh, and Sateesh Chodapuneedi.
>
>
> Bugs: 3301
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Issue:
> When VM is getting deployed in ZWPS(kvm, vmware), NPE is occuring.
>
> Fixed:
> SolidFire storage had introduced iops, its setting capacityIops on the pool level. Only solidfire is setting and getting it which is causing NPE when checking this value for other type PS.
> This fixed will resolve the issue for any storage provider which don't set capacityIops.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/StorageManagerImpl.java bb21afb
>
> Diff: https://reviews.apache.org/r/12227/diff/
>
>
> Testing
> -------
>
> 1. Adding ZWPS, and deployed the VM in KVM. Vm got successfully deployed.
> 2. Adding CWPS and deployed the VM in KVM. VM got deployed successfully.
>
>
> Thanks,
>
> Rajesh Battala
>
>
Re: Review Request 12227: NPE while deploying any instances in kvm/vmware
using ZWPS due to capacityIops
Posted by Rajesh Battala <ra...@citrix.com>.
> On July 10, 2013, 9:57 p.m., edison su wrote:
> > Ship It!
Thanks Edison for the review and pushing the patch
- Rajesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12227/#review22981
-----------------------------------------------------------
On July 4, 2013, 12:32 p.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12227/
> -----------------------------------------------------------
>
> (Updated July 4, 2013, 12:32 p.m.)
>
>
> Review request for cloudstack, edison su, Ram Ganesh, and Sateesh Chodapuneedi.
>
>
> Bugs: 3301
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Issue:
> When VM is getting deployed in ZWPS(kvm, vmware), NPE is occuring.
>
> Fixed:
> SolidFire storage had introduced iops, its setting capacityIops on the pool level. Only solidfire is setting and getting it which is causing NPE when checking this value for other type PS.
> This fixed will resolve the issue for any storage provider which don't set capacityIops.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/StorageManagerImpl.java bb21afb
>
> Diff: https://reviews.apache.org/r/12227/diff/
>
>
> Testing
> -------
>
> 1. Adding ZWPS, and deployed the VM in KVM. Vm got successfully deployed.
> 2. Adding CWPS and deployed the VM in KVM. VM got deployed successfully.
>
>
> Thanks,
>
> Rajesh Battala
>
>
Re: Review Request 12227: NPE while deploying any instances in kvm/vmware
using ZWPS due to capacityIops
Posted by edison su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12227/#review22981
-----------------------------------------------------------
Ship it!
Ship It!
- edison su
On July 4, 2013, 12:32 p.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12227/
> -----------------------------------------------------------
>
> (Updated July 4, 2013, 12:32 p.m.)
>
>
> Review request for cloudstack, edison su, Ram Ganesh, and Sateesh Chodapuneedi.
>
>
> Bugs: 3301
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Issue:
> When VM is getting deployed in ZWPS(kvm, vmware), NPE is occuring.
>
> Fixed:
> SolidFire storage had introduced iops, its setting capacityIops on the pool level. Only solidfire is setting and getting it which is causing NPE when checking this value for other type PS.
> This fixed will resolve the issue for any storage provider which don't set capacityIops.
>
>
> Diffs
> -----
>
> server/src/com/cloud/storage/StorageManagerImpl.java bb21afb
>
> Diff: https://reviews.apache.org/r/12227/diff/
>
>
> Testing
> -------
>
> 1. Adding ZWPS, and deployed the VM in KVM. Vm got successfully deployed.
> 2. Adding CWPS and deployed the VM in KVM. VM got deployed successfully.
>
>
> Thanks,
>
> Rajesh Battala
>
>