You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/01/29 06:52:51 UTC

[GitHub] [shardingsphere] sandynz opened a new pull request #15181: Show detailed error message to end user when scaling job does not exist

sandynz opened a new pull request #15181:
URL: https://github.com/apache/shardingsphere/pull/15181


   Fixes #15179.
   
   Changes proposed in this pull request:
   - Show detailed error message to end user when job does not exist
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang merged pull request #15181: Show detailed error message to end user when scaling job does not exist

Posted by GitBox <gi...@apache.org>.
RaigorJiang merged pull request #15181:
URL: https://github.com/apache/shardingsphere/pull/15181


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] sandynz commented on pull request #15181: Show detailed error message to end user when scaling job does not exist

Posted by GitBox <gi...@apache.org>.
sandynz commented on pull request #15181:
URL: https://github.com/apache/shardingsphere/pull/15181#issuecomment-1024852064


   If `job` doesn't exist, ejob `JobConfigurationAPIImpl.getJobConfiguration` will retur null:
   ```
       public JobConfigurationPOJO getJobConfiguration(final String jobName) {
           String yamlContent = regCenter.get(new JobNodePath(jobName).getConfigNodePath());
           if (null == yamlContent) {
               return null;
           }
           return YamlEngine.unmarshal(yamlContent, JobConfigurationPOJO.class);
       }
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org