You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2014/09/03 23:35:19 UTC

Review Request 25313: Use Optiq's native FieldTrimmer instead of HiveRelFieldTrimmer

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25313/
-----------------------------------------------------------

Review request for hive and Harish Butani.


Bugs: HIVE-7969
    https://issues.apache.org/jira/browse/HIVE-7969


Repository: hive-git


Description
-------

Use Optiq's native FieldTrimmer instead of HiveRelFieldTrimmer


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/HiveOptiqUtil.java e9b258e 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/TraitsUtil.java e8069ee 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveAggregateRel.java 1588cdf 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveJoinRel.java 6a3410b 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveProjectRel.java 8cbf2f1 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveSortRel.java 1c42a29 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveUnionRel.java b81f3c8 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/rules/HiveRelFieldTrimmer.java c28f974 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8fe8b3c 

Diff: https://reviews.apache.org/r/25313/diff/


Testing
-------

cbo_correctness.q passes


Thanks,

Ashutosh Chauhan


Re: Review Request 25313: Use Optiq's native FieldTrimmer instead of HiveRelFieldTrimmer

Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25313/#review52263
-----------------------------------------------------------

Ship it!


Ship It!

- John Pullokkaran


On Sept. 3, 2014, 9:35 p.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25313/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2014, 9:35 p.m.)
> 
> 
> Review request for hive and Harish Butani.
> 
> 
> Bugs: HIVE-7969
>     https://issues.apache.org/jira/browse/HIVE-7969
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Use Optiq's native FieldTrimmer instead of HiveRelFieldTrimmer
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/HiveOptiqUtil.java e9b258e 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/TraitsUtil.java e8069ee 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveAggregateRel.java 1588cdf 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveJoinRel.java 6a3410b 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveProjectRel.java 8cbf2f1 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveSortRel.java 1c42a29 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/reloperators/HiveUnionRel.java b81f3c8 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/rules/HiveRelFieldTrimmer.java c28f974 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8fe8b3c 
> 
> Diff: https://reviews.apache.org/r/25313/diff/
> 
> 
> Testing
> -------
> 
> cbo_correctness.q passes
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>