[jira] [Commented] (GEODE-7486) IndexManager is not consistent

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980158#comment-16980158 ] 

ASF subversion and git services commented on GEODE-7486:
--------------------------------------------------------

Commit ee2c20ba6ea83add067a6f2e85faf7cbb83e3b45 in geode's branch refs/heads/develop from Juan José Ramos
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ee2c20b ]

GEODE-7486: Fix IndexManager (#4353)

- Added unit and integration tests for the IndexManager class.
- Fixed IndexManager to mark indexes as invalid whenever there's an
  exception while adding or removing a mapping from the index.
- Improved log message shown whenever there's an error while updating
  indexes.

> IndexManager is not consistent
> ------------------------------
>
>                 Key: GEODE-7486
>                 URL: https://issues.apache.org/jira/browse/GEODE-7486
>             Project: Geode
>          Issue Type: Bug
>          Components: querying
>            Reporter: Juan Ramos
>            Assignee: Juan Ramos
>            Priority: Major
>              Labels: GeodeCommons
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> While working on GEODE-7351, I've found that the current {{IndexManager}} behaviour is not consistent:
> * If there's an exception thrown while adding an index mapping, we eat the exception, log an useless warning, and mark the index as invalid.
> * If there's an exception thrown while removing an index mapping, we re-throw the exception and leave the index as it is, even though it should be marked as invalid as well.
> The {{IndexManager}} should behave consistently and mark the index as {{invalid}} in both situations, clearly logging what went wrong while adding/removing the mapping.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)