You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/11/13 08:49:24 UTC

[GitHub] [zeppelin] zjffdu opened a new pull request #3970: [ZEPPELIN-5131]. Code completion pop up error message in shell interpreter

zjffdu opened a new pull request #3970:
URL: https://github.com/apache/zeppelin/pull/3970


   
   ### What is this PR for?
   
   Minor PR to fix the code completion pop up issue in shell interpreter. Besides that, I also did some code refactoring in this PR.
   
   ### What type of PR is it?
   [Bug Fix | Improvement ]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-5131
   
   ### How should this be tested?
   * CI pass
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #3970: [ZEPPELIN-5131]. Code completion pop up error message in shell interpreter

Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #3970:
URL: https://github.com/apache/zeppelin/pull/3970#issuecomment-726819358


   Can you please avoid String concatenation during logging, because Strings are immutable.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] asfgit closed pull request #3970: [ZEPPELIN-5131]. Code completion pop up error message in shell interpreter

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3970:
URL: https://github.com/apache/zeppelin/pull/3970


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on pull request #3970: [ZEPPELIN-5131]. Code completion pop up error message in shell interpreter

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #3970:
URL: https://github.com/apache/zeppelin/pull/3970#issuecomment-727872950


   @Reamer Thanks for the review, I have fixed string concatenation


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org