You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by justinleet <gi...@git.apache.org> on 2017/10/12 13:26:34 UTC
[GitHub] metron pull request #798: METRON-1247: REST search and findOne endpoints ret...
GitHub user justinleet opened a pull request:
https://github.com/apache/metron/pull/798
METRON-1247: REST search and findOne endpoints return unexpected or incorrect results for guids
## Contributor Comments
Updates documentation to have users surround GUIDs in double quotes in the search API.
Updates `ElasticsearchDao` to have findOne to use the`IdsQuery`, rather than a match query. This works because our guid is our id now, and this won't be subject to the analyzer.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/justinleet/metron METRON-1247
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/798.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #798
----
commit 351a5e4057f2b2a87034304472d45fbe182a2820
Author: justinjleet <ju...@gmail.com>
Date: 2017-10-12T11:32:35Z
Updated to use Ids query and added test for getLatest
----
---
[GitHub] metron issue #798: METRON-1247: REST search and findOne endpoints return une...
Posted by justinleet <gi...@git.apache.org>.
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/798
To test this spin up full dev and go to the Swagger API.
An unquoted search can result in multiple results that only partially match. These matches may be across sensors.
For all the below queries, it'll be necessary to do your own querying to get appropriate GUIDs. These are just what my machine generated on full-dev.
Example query.
```
{
"indices": ["websphere", "snort", "asa", "bro", "yaf"],
"query": "guid:a2d7ba04-d335-4948-8bc8-c889e7c531c9",
"from": 0,
"size": 500
}
```
e.g.
```
{
...
"id": "cabb2468-d827-4948-8137-71694ad85944",
...
"id": "58f975ae-0bd0-4948-91d7-fd433b29cd49",
...
"id": "a2d7ba04-d335-4948-8bc8-c889e7c531c9",
...
```
Now make the query against `findOne` and ensure it produces the correct record:
```
{
"guid": "a2d7ba04-d335-4948-8bc8-c889e7c531c9",
"sensorType": "bro"
}
```
Now try again with one of the partial matches and ensure it also produces the correct record.:
```
{
"guid": "cabb2468-d827-4948-8137-71694ad85944",
"sensorType": "bro"
}
```
Feel free to try this with more of the partial matches. All should return the correct record now, rather than mismatching.
---
[GitHub] metron pull request #798: METRON-1247: REST search and findOne endpoints ret...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/798
---
[GitHub] metron issue #798: METRON-1247: REST search and findOne endpoints return une...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/798
+1 by inspection, good job!
---