You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Mackie Mathew <mc...@gmail.com> on 2008/06/17 13:42:43 UTC

[harmony-demo-1] Issues in JComponent Fixed

The patches below addresses issues that were present in JComponent that
failed tests of JComponentTest.

https://issues.apache.org/jira/browse/HARMONY-5875
https://issues.apache.org/jira/browse/HARMONY-5874

Regards,

Tharindu

Re: [harmony-demo-1] Issues in JComponent Fixed

Posted by Mark Hindess <ma...@googlemail.com>.
In message <c3...@mail.gmail.com>, "Alex
ei Fedotov" writes:
>
> Sorry, Tharindu,
> In your previous letter you mention the patch you have just submitted.
> Would you please give a pointer to JIRA so I could review it and try
> for my test run?

I've just committed changes for HARMONY-5891 and HARMONY-5892 which I
assume are the ones Tharindu meant.

-Mark.

Re: [harmony-demo-1] Issues in JComponent Fixed

Posted by Mackie Mathew <mc...@gmail.com>.
https://issues.apache.org/jira/browse/HARMONY-5891
https://issues.apache.org/jira/browse/HARMONY-5892

I've submitted around 10 patches now. I feel I can submit a few more by the
14th. I'm a bit unclear about the deadline do we have to submit on the 7th
or on the 14th?

Regards,

Tharindu

On Wed, Jul 2, 2008 at 4:54 PM, Alexei Fedotov <al...@gmail.com>
wrote:

> Sorry, Tharindu,
> In your previous letter you mention the patch you have just submitted.
> Would you please give a pointer to JIRA so I could review it and try
> for my test run?
>
> Thanks!
>
> On Wed, Jul 2, 2008 at 2:35 PM, Mackie Mathew <mc...@gmail.com> wrote:
> > Hi Alexei,
> >
> > Sorry for the late reply. Our semester is approaching the mid terms and
> I've
> > had to complete a few assignments. Started working on some patches today
> > again.
> >
> > I took your advice and started trying out things and made some good
> > progress. I have gotten the hang of how to approach the whole project
> now.
> >
> > I thought the DebugGraphics class wasn't supposed to implement that
> method.
> > That's why I took that measure to correct the error. (by checking for
> type).
> >
> > I ran the whole swing test suite and got 137 errors. (Fixed up 2 today
> and
> > just submitted the patch). I ran it through Eclipse.
> >
> > Regards,
> >
> > Tharindu
> >
> > On Tue, Jul 1, 2008 at 8:05 PM, Alexei Fedotov <alexei.fedotov@gmail.com
> >
> > wrote:
> >
> >> Hello Tharindu,
> >>
> >> I'm sorry for being offine for a while. It seems you have made a good
> >> progress. I will try to catch up with you in few days. Mark, thank you
> >> for taking care of the fixes.
> >>
> >> I have a question concerning a patch for HARMONY-5874. Why are we
> >> adding a kludge to javax/swing/JComponent instead of adding an empty
> >> method to DebugGraphics class?
> >>
> >> Thanks!
> >>
> >> BTW, today I was running swing unit tests in my new environment and
> >> saw 179 errors. How this relates to your test status?
> >> $ ant test -Dbuild.module=swing
> >> -Dtest.jre.home=c:/work/1a/hdk/target/hdk/jdk/jre/
> >>
> >> On Tue, Jun 17, 2008 at 3:42 PM, Mackie Mathew <mc...@gmail.com>
> >> wrote:
> >> > The patches below addresses issues that were present in JComponent
> that
> >> > failed tests of JComponentTest.
> >> >
> >> > https://issues.apache.org/jira/browse/HARMONY-5875
> >> > https://issues.apache.org/jira/browse/HARMONY-5874
> >> >
> >> > Regards,
> >> >
> >> > Tharindu
> >> >
> >>
> >>
> >>
> >> --
> >> With best regards,
> >> Alexei
> >>
> >
>
>
>
> --
> With best regards,
> Alexei
>

Re: [harmony-demo-1] Issues in JComponent Fixed

Posted by Alexei Fedotov <al...@gmail.com>.
Sorry, Tharindu,
In your previous letter you mention the patch you have just submitted.
Would you please give a pointer to JIRA so I could review it and try
for my test run?

Thanks!

On Wed, Jul 2, 2008 at 2:35 PM, Mackie Mathew <mc...@gmail.com> wrote:
> Hi Alexei,
>
> Sorry for the late reply. Our semester is approaching the mid terms and I've
> had to complete a few assignments. Started working on some patches today
> again.
>
> I took your advice and started trying out things and made some good
> progress. I have gotten the hang of how to approach the whole project now.
>
> I thought the DebugGraphics class wasn't supposed to implement that method.
> That's why I took that measure to correct the error. (by checking for type).
>
> I ran the whole swing test suite and got 137 errors. (Fixed up 2 today and
> just submitted the patch). I ran it through Eclipse.
>
> Regards,
>
> Tharindu
>
> On Tue, Jul 1, 2008 at 8:05 PM, Alexei Fedotov <al...@gmail.com>
> wrote:
>
>> Hello Tharindu,
>>
>> I'm sorry for being offine for a while. It seems you have made a good
>> progress. I will try to catch up with you in few days. Mark, thank you
>> for taking care of the fixes.
>>
>> I have a question concerning a patch for HARMONY-5874. Why are we
>> adding a kludge to javax/swing/JComponent instead of adding an empty
>> method to DebugGraphics class?
>>
>> Thanks!
>>
>> BTW, today I was running swing unit tests in my new environment and
>> saw 179 errors. How this relates to your test status?
>> $ ant test -Dbuild.module=swing
>> -Dtest.jre.home=c:/work/1a/hdk/target/hdk/jdk/jre/
>>
>> On Tue, Jun 17, 2008 at 3:42 PM, Mackie Mathew <mc...@gmail.com>
>> wrote:
>> > The patches below addresses issues that were present in JComponent that
>> > failed tests of JComponentTest.
>> >
>> > https://issues.apache.org/jira/browse/HARMONY-5875
>> > https://issues.apache.org/jira/browse/HARMONY-5874
>> >
>> > Regards,
>> >
>> > Tharindu
>> >
>>
>>
>>
>> --
>> With best regards,
>> Alexei
>>
>



-- 
With best regards,
Alexei

Re: [harmony-demo-1] Issues in JComponent Fixed

Posted by Alexei Fedotov <al...@gmail.com>.
Tharindu,
That's great! Keep going.

Let's start thinking what we can put into the mid-term evaluation for
GSoC (July, 6) [1].

[1] http://code.google.com/opensource/gsoc/2008/faqs.html#0.1_timeline

On Wed, Jul 2, 2008 at 2:35 PM, Mackie Mathew <mc...@gmail.com> wrote:
> Hi Alexei,
>
> Sorry for the late reply. Our semester is approaching the mid terms and I've
> had to complete a few assignments. Started working on some patches today
> again.
>
> I took your advice and started trying out things and made some good
> progress. I have gotten the hang of how to approach the whole project now.
>
> I thought the DebugGraphics class wasn't supposed to implement that method.
> That's why I took that measure to correct the error. (by checking for type).
>
> I ran the whole swing test suite and got 137 errors. (Fixed up 2 today and
> just submitted the patch). I ran it through Eclipse.
>
> Regards,
>
> Tharindu
>
> On Tue, Jul 1, 2008 at 8:05 PM, Alexei Fedotov <al...@gmail.com>
> wrote:
>
>> Hello Tharindu,
>>
>> I'm sorry for being offine for a while. It seems you have made a good
>> progress. I will try to catch up with you in few days. Mark, thank you
>> for taking care of the fixes.
>>
>> I have a question concerning a patch for HARMONY-5874. Why are we
>> adding a kludge to javax/swing/JComponent instead of adding an empty
>> method to DebugGraphics class?
>>
>> Thanks!
>>
>> BTW, today I was running swing unit tests in my new environment and
>> saw 179 errors. How this relates to your test status?
>> $ ant test -Dbuild.module=swing
>> -Dtest.jre.home=c:/work/1a/hdk/target/hdk/jdk/jre/
>>
>> On Tue, Jun 17, 2008 at 3:42 PM, Mackie Mathew <mc...@gmail.com>
>> wrote:
>> > The patches below addresses issues that were present in JComponent that
>> > failed tests of JComponentTest.
>> >
>> > https://issues.apache.org/jira/browse/HARMONY-5875
>> > https://issues.apache.org/jira/browse/HARMONY-5874
>> >
>> > Regards,
>> >
>> > Tharindu
>> >
>>
>>
>>
>> --
>> With best regards,
>> Alexei
>>
>



-- 
With best regards,
Alexei

Re: [harmony-demo-1] Issues in JComponent Fixed

Posted by Mackie Mathew <mc...@gmail.com>.
Hi Alexei,

Sorry for the late reply. Our semester is approaching the mid terms and I've
had to complete a few assignments. Started working on some patches today
again.

I took your advice and started trying out things and made some good
progress. I have gotten the hang of how to approach the whole project now.

I thought the DebugGraphics class wasn't supposed to implement that method.
That's why I took that measure to correct the error. (by checking for type).

I ran the whole swing test suite and got 137 errors. (Fixed up 2 today and
just submitted the patch). I ran it through Eclipse.

Regards,

Tharindu

On Tue, Jul 1, 2008 at 8:05 PM, Alexei Fedotov <al...@gmail.com>
wrote:

> Hello Tharindu,
>
> I'm sorry for being offine for a while. It seems you have made a good
> progress. I will try to catch up with you in few days. Mark, thank you
> for taking care of the fixes.
>
> I have a question concerning a patch for HARMONY-5874. Why are we
> adding a kludge to javax/swing/JComponent instead of adding an empty
> method to DebugGraphics class?
>
> Thanks!
>
> BTW, today I was running swing unit tests in my new environment and
> saw 179 errors. How this relates to your test status?
> $ ant test -Dbuild.module=swing
> -Dtest.jre.home=c:/work/1a/hdk/target/hdk/jdk/jre/
>
> On Tue, Jun 17, 2008 at 3:42 PM, Mackie Mathew <mc...@gmail.com>
> wrote:
> > The patches below addresses issues that were present in JComponent that
> > failed tests of JComponentTest.
> >
> > https://issues.apache.org/jira/browse/HARMONY-5875
> > https://issues.apache.org/jira/browse/HARMONY-5874
> >
> > Regards,
> >
> > Tharindu
> >
>
>
>
> --
> With best regards,
> Alexei
>

Re: [harmony-demo-1] Issues in JComponent Fixed

Posted by Alexei Fedotov <al...@gmail.com>.
Hello Tharindu,

I'm sorry for being offine for a while. It seems you have made a good
progress. I will try to catch up with you in few days. Mark, thank you
for taking care of the fixes.

I have a question concerning a patch for HARMONY-5874. Why are we
adding a kludge to javax/swing/JComponent instead of adding an empty
method to DebugGraphics class?

Thanks!

BTW, today I was running swing unit tests in my new environment and
saw 179 errors. How this relates to your test status?
$ ant test -Dbuild.module=swing
-Dtest.jre.home=c:/work/1a/hdk/target/hdk/jdk/jre/

On Tue, Jun 17, 2008 at 3:42 PM, Mackie Mathew <mc...@gmail.com> wrote:
> The patches below addresses issues that were present in JComponent that
> failed tests of JComponentTest.
>
> https://issues.apache.org/jira/browse/HARMONY-5875
> https://issues.apache.org/jira/browse/HARMONY-5874
>
> Regards,
>
> Tharindu
>



-- 
With best regards,
Alexei