You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/30 15:44:39 UTC

[GitHub] [spark] MaxGekk commented on a change in pull request #24742: [SPARK-27881][SQL] Support CAST (... FORMAT ) expression

MaxGekk commented on a change in pull request #24742: [SPARK-27881][SQL] Support CAST (... FORMAT <pattern>) expression
URL: https://github.com/apache/spark/pull/24742#discussion_r289042897
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
 ##########
 @@ -204,12 +206,17 @@ object Cast {
       > SELECT _FUNC_('10' as int);
        10
   """)
-case class Cast(child: Expression, dataType: DataType, timeZoneId: Option[String] = None)
+case class Cast(
+    child: Expression,
+    dataType: DataType,
+    timeZoneId: Option[String] = None,
+    format: Option[String] = None)
   extends UnaryExpression with TimeZoneAwareExpression with NullIntolerant {
 
   def this(child: Expression, dataType: DataType) = this(child, dataType, None)
 
-  override def toString: String = s"cast($child as ${dataType.simpleString})"
+  override def toString: String =
+    s"cast($child as ${dataType.simpleString}${format.map(" FORMAT " + _).getOrElse("")})"
 
 Review comment:
   nit: Make `FORMAT` in lower case as `cast` and `as`  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org