You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/08 17:02:32 UTC
[GitHub] [incubator-seatunnel] asdf2014 opened a new pull request #982: [SeaTunnel#981] Add Code Inspection to ensure code quality
asdf2014 opened a new pull request #982:
URL: https://github.com/apache/incubator-seatunnel/pull/982
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[SeaTunnel #XXXX] [component] Title of the pull request", where *SeaTunnel #XXXX* should be replaced by the actual issue number.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
Fixes #981
## Check list
* [x] Code changed are covered with tests, or it does not need tests for reason:
* [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #982: [SeaTunnel#981] Add Code Inspection to ensure code quality
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #982:
URL: https://github.com/apache/incubator-seatunnel/pull/982#discussion_r781156770
##########
File path: .idea/inspectionProfiles/SeaTunnel.xml
##########
@@ -0,0 +1,19 @@
+<component name="InspectionProjectProfileManager">
Review comment:
Hi @CalvinKirs . Thanks for your comment. You can get more details from [here](https://github.com/apache/druid/tree/master/.idea) for now. In future, I will create another PRs to apply these features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs closed pull request #982: [SeaTunnel#981] Add Code Inspection to ensure code quality
Posted by GitBox <gi...@apache.org>.
CalvinKirs closed pull request #982:
URL: https://github.com/apache/incubator-seatunnel/pull/982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on a change in pull request #982: [SeaTunnel#981] Add Code Inspection to ensure code quality
Posted by GitBox <gi...@apache.org>.
leo65535 commented on a change in pull request #982:
URL: https://github.com/apache/incubator-seatunnel/pull/982#discussion_r780867356
##########
File path: .idea/inspectionProfiles/SeaTunnel.xml
##########
@@ -0,0 +1,19 @@
+<component name="InspectionProjectProfileManager">
Review comment:
We can add following check rule to `checkstyle.xml`
https://checkstyle.sourceforge.io/config_misc.html#Indentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on a change in pull request #982: [SeaTunnel#981] Add Code Inspection to ensure code quality
Posted by GitBox <gi...@apache.org>.
leo65535 commented on a change in pull request #982:
URL: https://github.com/apache/incubator-seatunnel/pull/982#discussion_r780858094
##########
File path: .idea/inspectionProfiles/SeaTunnel.xml
##########
@@ -0,0 +1,19 @@
+<component name="InspectionProjectProfileManager">
Review comment:
hi @asdf2014, we already have a `maven-checkstyle-plugin` with `checkstyle.xml` to help us check the code style. Can we use `maven-checkstyle-plugin` to check the inspection?
And, we can use `mvn checkstyle:check` to check code style when we use `mvn-checkstyle-plugin`, how we can check the inspection after add this profile file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #982: [SeaTunnel#981] Add Code Inspection to ensure code quality
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #982:
URL: https://github.com/apache/incubator-seatunnel/pull/982#discussion_r780901318
##########
File path: .idea/inspectionProfiles/SeaTunnel.xml
##########
@@ -0,0 +1,19 @@
+<component name="InspectionProjectProfileManager">
Review comment:
@leo65535 You are welcome. This is just the beginning, the .idea can do more than you imagine, and I will raise up more follow-up PRs to empower our project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on a change in pull request #982: [SeaTunnel#981] Add Code Inspection to ensure code quality
Posted by GitBox <gi...@apache.org>.
leo65535 commented on a change in pull request #982:
URL: https://github.com/apache/incubator-seatunnel/pull/982#discussion_r780898218
##########
File path: .idea/inspectionProfiles/SeaTunnel.xml
##########
@@ -0,0 +1,19 @@
+<component name="InspectionProjectProfileManager">
Review comment:
Thanks @asdf2014, just from my side, I prefer to don't add files to `.idea` folder. `maven-checkstyle-plugin` is enough for us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #982: [SeaTunnel#981] Add Code Inspection to ensure code quality
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #982:
URL: https://github.com/apache/incubator-seatunnel/pull/982#issuecomment-1009528140
clode by #997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 closed pull request #982: [SeaTunnel#981] Add Code Inspection to ensure code quality
Posted by GitBox <gi...@apache.org>.
asdf2014 closed pull request #982:
URL: https://github.com/apache/incubator-seatunnel/pull/982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on a change in pull request #982: [SeaTunnel#981] Add Code Inspection to ensure code quality
Posted by GitBox <gi...@apache.org>.
leo65535 commented on a change in pull request #982:
URL: https://github.com/apache/incubator-seatunnel/pull/982#discussion_r780858094
##########
File path: .idea/inspectionProfiles/SeaTunnel.xml
##########
@@ -0,0 +1,19 @@
+<component name="InspectionProjectProfileManager">
Review comment:
hi @asdf2014, we already have a `maven-checkstyle-plugin` with `checkstyle.xml` to help us check the code style. Can we use `maven-checkstyle-plugin` to check the indentation?
And, we can use `mvn checkstyle:check` to check code style when we use `mvn-checkstyle-plugin`, how we can check the inspection after add this profile file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] cody1993 commented on a change in pull request #982: [SeaTunnel#981] Add Code Inspection to ensure code quality
Posted by GitBox <gi...@apache.org>.
cody1993 commented on a change in pull request #982:
URL: https://github.com/apache/incubator-seatunnel/pull/982#discussion_r781692872
##########
File path: .idea/inspectionProfiles/SeaTunnel.xml
##########
@@ -0,0 +1,19 @@
+<component name="InspectionProjectProfileManager">
Review comment:
+1, don't add profile files to `.idea` folder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #982: [SeaTunnel#981] Add Code Inspection to ensure code quality
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #982:
URL: https://github.com/apache/incubator-seatunnel/pull/982#discussion_r781119111
##########
File path: .idea/inspectionProfiles/SeaTunnel.xml
##########
@@ -0,0 +1,19 @@
+<component name="InspectionProjectProfileManager">
Review comment:
I have the same opinion as leo, but I'm looking forward to your other about `idea` revamps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #982: [SeaTunnel#981] Add Code Inspection to ensure code quality
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #982:
URL: https://github.com/apache/incubator-seatunnel/pull/982#discussion_r780899541
##########
File path: .idea/inspectionProfiles/SeaTunnel.xml
##########
@@ -0,0 +1,19 @@
+<component name="InspectionProjectProfileManager">
Review comment:
Hah, you can try it out, the Code Inspection is great, it will remind you in real-time while you are coding, and can automatically fix up your code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 closed pull request #982: [SeaTunnel#981] Add Code Inspection to ensure code quality
Posted by GitBox <gi...@apache.org>.
asdf2014 closed pull request #982:
URL: https://github.com/apache/incubator-seatunnel/pull/982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs edited a comment on pull request #982: [SeaTunnel#981] Add Code Inspection to ensure code quality
Posted by GitBox <gi...@apache.org>.
CalvinKirs edited a comment on pull request #982:
URL: https://github.com/apache/incubator-seatunnel/pull/982#issuecomment-1009528140
close by #997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] asdf2014 commented on a change in pull request #982: [SeaTunnel#981] Add Code Inspection to ensure code quality
Posted by GitBox <gi...@apache.org>.
asdf2014 commented on a change in pull request #982:
URL: https://github.com/apache/incubator-seatunnel/pull/982#discussion_r780876126
##########
File path: .idea/inspectionProfiles/SeaTunnel.xml
##########
@@ -0,0 +1,19 @@
+<component name="InspectionProjectProfileManager">
Review comment:
Hi, @leo65535 . Thanks a lot for your comments. The `maven-checkstyle-plugin` is in the `compile` stage after we finished coding, however the `Code Inspection` is earlier than that, and it will remain us while we are coding. Therefore, they are working on different processes to ensure code quality, which is necessary for us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org