You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "c-thiel (via GitHub)" <gi...@apache.org> on 2023/04/11 16:41:01 UTC
[GitHub] [arrow-rs] c-thiel opened a new pull request, #4055: Add CommandGetXdbcTypeInfo to Flight SQL Server
c-thiel opened a new pull request, #4055:
URL: https://github.com/apache/arrow-rs/pull/4055
# Which issue does this PR close?
Closes #4054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] avantgardnerio commented on pull request #4055: Add CommandGetXdbcTypeInfo to Flight SQL Server
Posted by "avantgardnerio (via GitHub)" <gi...@apache.org>.
avantgardnerio commented on PR #4055:
URL: https://github.com/apache/arrow-rs/pull/4055#issuecomment-1505437476
> NVM, I had a buggy ODBC driver
This is why I think integration testing is almost as important as manually trying to interpret the spec. IMO we should try stuff with the JDBC / ODBC drivers, record what happens, then try to mimic those tests with the Rust client and add them to the test suite.
I wouldn't want to merge the change that breaks something about JDBC that others are actively using.
In the case of `CommandStatementQuery` specifically, I wouldn't be surprised if that isn't working properly, since I've only been testing with JDBC and that driver always seems to turn everything into a prepared statement, even if on the Java side the user asks for an un-prepared statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] c-thiel commented on pull request #4055: Add CommandGetXdbcTypeInfo to Flight SQL Server
Posted by "c-thiel (via GitHub)" <gi...@apache.org>.
c-thiel commented on PR #4055:
URL: https://github.com/apache/arrow-rs/pull/4055#issuecomment-1505379165
Actually, this deserves a separate issue. I don't quite agree with the do_get_statement method. I will link it here when its created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #4055: Add CommandGetXdbcTypeInfo to Flight SQL Server
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #4055:
URL: https://github.com/apache/arrow-rs/pull/4055#issuecomment-1505735035
> IMO we should try stuff with the JDBC / ODBC drivers, record what happens
I agree -- I think this testing is covered by https://github.com/apache/arrow-rs/issues/2409. I agree it would be a fantastic additio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #4055: Add CommandGetXdbcTypeInfo to Flight SQL Server
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #4055:
URL: https://github.com/apache/arrow-rs/pull/4055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] c-thiel commented on pull request #4055: Add CommandGetXdbcTypeInfo to Flight SQL Server
Posted by "c-thiel (via GitHub)" <gi...@apache.org>.
c-thiel commented on PR #4055:
URL: https://github.com/apache/arrow-rs/pull/4055#issuecomment-1505063076
Before we merge, I noticed that the same method is also missing for the client. I am adding it as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] c-thiel commented on pull request #4055: Add CommandGetXdbcTypeInfo to Flight SQL Server
Posted by "c-thiel (via GitHub)" <gi...@apache.org>.
c-thiel commented on PR #4055:
URL: https://github.com/apache/arrow-rs/pull/4055#issuecomment-1505364485
@alamb / @avantgardnerio :
I am missing another quite similar function - currently a do_get with cmd arrow.flight.protocol.sql.CommandStatementQuery executes the `do_get_fallback` method of the server. This is not caught in the match.
Should I add a new PR or do you prefer to extend this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org