You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by tg...@apache.org on 2017/03/24 16:41:54 UTC

[1/2] beam git commit: This closes #2310

Repository: beam
Updated Branches:
  refs/heads/master 14aba8125 -> 741242732


This closes #2310


Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/74124273
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/74124273
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/74124273

Branch: refs/heads/master
Commit: 7412427327c8c66e91e8d4c141854d1df343c1e0
Parents: 14aba81 92cdc08
Author: Thomas Groh <tg...@google.com>
Authored: Fri Mar 24 09:41:42 2017 -0700
Committer: Thomas Groh <tg...@google.com>
Committed: Fri Mar 24 09:41:42 2017 -0700

----------------------------------------------------------------------
 .../apache/beam/runners/flink/FlinkRunner.java    | 18 ------------------
 1 file changed, 18 deletions(-)
----------------------------------------------------------------------



[2/2] beam git commit: Remove unused field in FlinkRunner

Posted by tg...@apache.org.
Remove unused field in FlinkRunner

These overrides are performed in FlinkStreamingPipelineTranslator


Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/92cdc089
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/92cdc089
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/92cdc089

Branch: refs/heads/master
Commit: 92cdc0891f33afdc0ef7545fbd812532555631ff
Parents: 14aba81
Author: Thomas Groh <tg...@google.com>
Authored: Thu Mar 23 15:52:22 2017 -0700
Committer: Thomas Groh <tg...@google.com>
Committed: Fri Mar 24 09:41:42 2017 -0700

----------------------------------------------------------------------
 .../apache/beam/runners/flink/FlinkRunner.java    | 18 ------------------
 1 file changed, 18 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/beam/blob/92cdc089/runners/flink/runner/src/main/java/org/apache/beam/runners/flink/FlinkRunner.java
----------------------------------------------------------------------
diff --git a/runners/flink/runner/src/main/java/org/apache/beam/runners/flink/FlinkRunner.java b/runners/flink/runner/src/main/java/org/apache/beam/runners/flink/FlinkRunner.java
index 5610dd4..096f030 100644
--- a/runners/flink/runner/src/main/java/org/apache/beam/runners/flink/FlinkRunner.java
+++ b/runners/flink/runner/src/main/java/org/apache/beam/runners/flink/FlinkRunner.java
@@ -18,7 +18,6 @@
 package org.apache.beam.runners.flink;
 
 import com.google.common.base.Joiner;
-import com.google.common.collect.ImmutableMap;
 import java.io.File;
 import java.net.URISyntaxException;
 import java.net.URL;
@@ -36,7 +35,6 @@ import org.apache.beam.sdk.options.PipelineOptions;
 import org.apache.beam.sdk.options.PipelineOptionsValidator;
 import org.apache.beam.sdk.runners.PipelineRunner;
 import org.apache.beam.sdk.runners.TransformHierarchy;
-import org.apache.beam.sdk.transforms.Combine;
 import org.apache.beam.sdk.transforms.PTransform;
 import org.apache.beam.sdk.transforms.View;
 import org.apache.beam.sdk.values.PValue;
@@ -59,9 +57,6 @@ public class FlinkRunner extends PipelineRunner<PipelineResult> {
    */
   private final FlinkPipelineOptions options;
 
-  /** Custom transforms implementations. */
-  private final Map<Class<?>, Class<?>> overrides;
-
   /**
    * Construct a runner from the provided options.
    *
@@ -102,19 +97,6 @@ public class FlinkRunner extends PipelineRunner<PipelineResult> {
   private FlinkRunner(FlinkPipelineOptions options) {
     this.options = options;
     this.ptransformViewsWithNonDeterministicKeyCoders = new HashSet<>();
-
-    ImmutableMap.Builder<Class<?>, Class<?>> builder = ImmutableMap.<Class<?>, Class<?>>builder();
-    if (options.isStreaming()) {
-      builder.put(Combine.GloballyAsSingletonView.class,
-          FlinkStreamingViewOverrides.StreamingCombineGloballyAsSingletonView.class);
-      builder.put(View.AsMap.class, FlinkStreamingViewOverrides.StreamingViewAsMap.class);
-      builder.put(View.AsMultimap.class, FlinkStreamingViewOverrides.StreamingViewAsMultimap.class);
-      builder.put(View.AsSingleton.class,
-          FlinkStreamingViewOverrides.StreamingViewAsSingleton.class);
-      builder.put(View.AsList.class, FlinkStreamingViewOverrides.StreamingViewAsList.class);
-      builder.put(View.AsIterable.class, FlinkStreamingViewOverrides.StreamingViewAsIterable.class);
-    }
-    overrides = builder.build();
   }
 
   @Override