You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/10/09 16:29:19 UTC

[GitHub] [trafficcontrol] rob05c commented on issue #3962: Add atscfg remap.config tests

rob05c commented on issue #3962: Add atscfg remap.config tests
URL: https://github.com/apache/trafficcontrol/pull/3962#issuecomment-540080137
 
 
   >I do think use of table driven tests 
   
   Huh, TIL. I do that a lot, didn't know it had a name.
   
   But, if we wanted to reduce the "duplicate" lines, I think some kind of `MakeDefaultServerInfo` would go farther, and then each test would modify what it cared about.
   
   I was on the fence about that. It'd reduce the lines of code, but I also kind of feel like it's good for each test to be completely independent, and saying "I'm testing exactly this data," and there's no shared func that would change all the tests if it were changed. 
   
   I went with the latter, but I'm personally not sure which is a "better" test 🤷‍♂ .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services