You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by bd...@apache.org on 2017/06/20 15:06:00 UTC
sling-site git commit: Downloads page was broken by mass front matter
change
Repository: sling-site
Updated Branches:
refs/heads/master 5141f273c -> bea9e33ea
Downloads page was broken by mass front matter change
Project: http://git-wip-us.apache.org/repos/asf/sling-site/repo
Commit: http://git-wip-us.apache.org/repos/asf/sling-site/commit/bea9e33e
Tree: http://git-wip-us.apache.org/repos/asf/sling-site/tree/bea9e33e
Diff: http://git-wip-us.apache.org/repos/asf/sling-site/diff/bea9e33e
Branch: refs/heads/master
Commit: bea9e33ea09218a730937591f787f3b69f29057b
Parents: 5141f27
Author: Bertrand Delacretaz <bd...@apache.org>
Authored: Tue Jun 20 17:05:43 2017 +0200
Committer: Bertrand Delacretaz <bd...@apache.org>
Committed: Tue Jun 20 17:05:43 2017 +0200
----------------------------------------------------------------------
README.md | 5 ++---
content/downloads.md | 4 ++--
templates/downloads.tpl | 2 +-
3 files changed, 5 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/sling-site/blob/bea9e33e/README.md
----------------------------------------------------------------------
diff --git a/README.md b/README.md
index d1714f0..f8cb6ab 100644
--- a/README.md
+++ b/README.md
@@ -22,8 +22,8 @@ TODO gitpubsub is not active so far, I will request a test setup to start with.
* Fix references like `refs.authentication-tasks.headers.excerpt` as well as `.title` references -> replace with copies of those titles and excerpts, or use tags to mark and select
* Fix remaining `refs.` links -> those are probably broken anyway
* The `#!java` macro is not supported -> convert to monospaced code
-* Finish the dynamic downloads page, links are still TODO + test with CGI script
-* sitemap page is missing
+* Test the downloads.cgi page, requires an apache.org setup (INFRA-14390)
+* Create sitemap page
### Nice to have
* JBake 2.5.x does not support the `[TOC]` macro but apparently that will be available once JBake moves to https://github.com/vsch/flexmark-java , probably in its next version. We might wait for that and just mark the TOCs as unsupported for now.
@@ -32,7 +32,6 @@ TODO gitpubsub is not active so far, I will request a test setup to start with.
### Final validation, activation etc.
* Review all pages
* Resync the content with the current Sling website if needed, initially synced at r1798604
-* Move the Git repository to apache.org, create an `asf-site` branch for the live content and ask infra to setup gitpubsub to activate it
### Done
* Fix internal links like `refs.project-information.path`
http://git-wip-us.apache.org/repos/asf/sling-site/blob/bea9e33e/content/downloads.md
----------------------------------------------------------------------
diff --git a/content/downloads.md b/content/downloads.md
index 8401189..f43c691 100644
--- a/content/downloads.md
+++ b/content/downloads.md
@@ -1,5 +1,5 @@
-title=
-type=page
+title=Downloads
+type=downloads
status=published
~~~~~~
http://git-wip-us.apache.org/repos/asf/sling-site/blob/bea9e33e/templates/downloads.tpl
----------------------------------------------------------------------
diff --git a/templates/downloads.tpl b/templates/downloads.tpl
index 89fa3e0..eaeabd3 100644
--- a/templates/downloads.tpl
+++ b/templates/downloads.tpl
@@ -287,7 +287,7 @@ layout 'layout/main.tpl', true,
td(data[0])
td(data[4])
td(data[1])
- var artifact = "${data[2]}-${data[4]}${data[3]}"
+ def artifact = "${data[2]}-${data[4]}${data[3]}"
td(){
downloadLink(artifact, artifact, "", "")
}