[GitHub] zhaoyu89730105 commented on a change in pull request #5285: [Distribution - Bar Chart] Sort bars add asc and desc

[GitBox <gi...@apache.org>]

zhaoyu89730105 commented on a change in pull request #5285: [Distribution - Bar Chart] Sort bars add asc and desc
URL: https://github.com/apache/incubator-superset/pull/5285#discussion_r199058475
 
 

 ##########
 File path: superset/assets/src/explore/controls.jsx
 ##########
 @@ -449,11 +449,16 @@ export const controls = {
   },
 
   order_bars: {
-    type: 'CheckboxControl',
+    type: 'SelectControl',
     label: t('Sort Bars'),
-    default: false,
-    renderTrigger: true,
+    default: 'unsort',
     description: t('Sort bars by x labels.'),
+    renderTrigger: true,
+    choices: formatSelectOptions([
+        'unsort',
 
 Review comment:
   The cancellation sort will be displayed in the original order of the data.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org