You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2016/03/01 21:04:02 UTC
Review Request 44222: Removed `grace_period_seconds` field from
executor API protobufs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44222/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone.
Bugs: MESOS-4829
https://issues.apache.org/jira/browse/MESOS-4829
Repository: mesos
Description
-------
This change removes the `grace_period_second` field from the
executor API protobufs. Instead, we would be relying on the environment
variable `MESOS_SHUTDOWN_GRACE_PERIOD` set by the agent.
Diffs
-----
include/mesos/executor/executor.proto e905a12e88e9a9e1382830974f7b4f82d83be51e
include/mesos/v1/executor/executor.proto dbbc2656461e32b47f5c9e2d3767ebdfe343368e
Diff: https://reviews.apache.org/r/44222/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 44222: Removed `grace_period_seconds` field from
executor API protobufs.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44222/
-----------------------------------------------------------
(Updated March 1, 2016, 9:27 p.m.)
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone.
Changes
-------
Updated description.
Bugs: MESOS-4829
https://issues.apache.org/jira/browse/MESOS-4829
Repository: mesos
Description (updated)
-------
This change removes the `grace_period_second` field from the
executor API protobufs. Instead, we would be relying on the environment
variable `MESOS_EXECUTOR_SHUTDOWN_GRACE_PERIOD` set by the agent.
Diffs
-----
include/mesos/executor/executor.proto e905a12e88e9a9e1382830974f7b4f82d83be51e
include/mesos/v1/executor/executor.proto dbbc2656461e32b47f5c9e2d3767ebdfe343368e
Diff: https://reviews.apache.org/r/44222/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 44222: Removed `grace_period_seconds` field from
executor API protobufs.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44222/
-----------------------------------------------------------
(Updated March 1, 2016, 9:14 p.m.)
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone.
Changes
-------
Fixed env name and a bit of jaggedness due to the env name.
Bugs: MESOS-4829
https://issues.apache.org/jira/browse/MESOS-4829
Repository: mesos
Description
-------
This change removes the `grace_period_second` field from the
executor API protobufs. Instead, we would be relying on the environment
variable `MESOS_SHUTDOWN_GRACE_PERIOD` set by the agent.
Diffs (updated)
-----
include/mesos/executor/executor.proto e905a12e88e9a9e1382830974f7b4f82d83be51e
include/mesos/v1/executor/executor.proto dbbc2656461e32b47f5c9e2d3767ebdfe343368e
Diff: https://reviews.apache.org/r/44222/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 44222: Removed `grace_period_seconds` field from
executor API protobufs.
Posted by Vinod Kone <vi...@gmail.com>.
> On March 1, 2016, 8:21 p.m., Vinod Kone wrote:
> > Ship It!
Can you update the env variable name in the description?
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44222/#review121487
-----------------------------------------------------------
On March 1, 2016, 9:14 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44222/
> -----------------------------------------------------------
>
> (Updated March 1, 2016, 9:14 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-4829
> https://issues.apache.org/jira/browse/MESOS-4829
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change removes the `grace_period_second` field from the
> executor API protobufs. Instead, we would be relying on the environment
> variable `MESOS_SHUTDOWN_GRACE_PERIOD` set by the agent.
>
>
> Diffs
> -----
>
> include/mesos/executor/executor.proto e905a12e88e9a9e1382830974f7b4f82d83be51e
> include/mesos/v1/executor/executor.proto dbbc2656461e32b47f5c9e2d3767ebdfe343368e
>
> Diff: https://reviews.apache.org/r/44222/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 44222: Removed `grace_period_seconds` field from
executor API protobufs.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44222/#review121487
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 1, 2016, 8:04 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44222/
> -----------------------------------------------------------
>
> (Updated March 1, 2016, 8:04 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-4829
> https://issues.apache.org/jira/browse/MESOS-4829
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change removes the `grace_period_second` field from the
> executor API protobufs. Instead, we would be relying on the environment
> variable `MESOS_SHUTDOWN_GRACE_PERIOD` set by the agent.
>
>
> Diffs
> -----
>
> include/mesos/executor/executor.proto e905a12e88e9a9e1382830974f7b4f82d83be51e
> include/mesos/v1/executor/executor.proto dbbc2656461e32b47f5c9e2d3767ebdfe343368e
>
> Diff: https://reviews.apache.org/r/44222/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>