You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by pbchou <gi...@git.apache.org> on 2016/06/07 00:51:38 UTC
[GitHub] trafficserver pull request #696: TS-3245: Made changes based on input from J...
GitHub user pbchou opened a pull request:
https://github.com/apache/trafficserver/pull/696
TS-3245: Made changes based on input from James Peach to allow
multiple global plugins to co-exist in the plugin.config file.
Also, made the same changes to allow remap plugins to co-exist
with each other in the remap.config file.
Specifically, on freebsd and darwin platforms we use
'optreset = 1' to reset the getopt_long() command line parser.
On Linux/glibc we use 'optind = 0' to reset the parser.
The parser must be reset between uses such as first loading
one plugin and then another.
The setting of these variables is now performed in ATS core
before the plugin initialization functions are called. The
setting of these variables inside of the individual plugins
has been removed. If a plugin needs to call getopt_long()
outside of the plugin global or remap intializations,
it should use the code in proxy/Plugin.cc as an example.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pbchou/trafficserver TS-3245-B
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/696.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #696
----
commit 114618ef3fb27280eb248dd2524bd0523df10507
Author: Peter Chou <pb...@labs.att.com>
Date: 2016-06-06T23:31:43Z
TS-3245: Made changes based on input from James Peach to allow
multiple global plugins to co-exist in the plugin.config file.
Also, made the same changes to allow remap plugins to co-exist
with each other in the remap.config file.
Specifically, on freebsd and darwin platforms we use
'optreset = 1' to reset the getopt_long() command line parser.
On Linux/glibc we use 'optind = 0' to reset the parser.
The parser must be reset between uses such as first loading
one plugin and then another.
The setting of these variables is now performed in ATS core
before the plugin initialization functions are called. The
setting of these variables inside of the individual plugins
has been removed. If a plugin needs to call getopt_long()
outside of the plugin global or remap intializations,
it should use the code in proxy/Plugin.cc as an example.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #696: TS-3245: Fixed reset of getopt_long() globa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/696
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #696: TS-3245: Fixed reset of getopt_long() global varia...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/696
Build finished.
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/74/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #696: TS-3245: Fixed reset of getopt_long() global varia...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/696
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #696: TS-3245: Fixed reset of getopt_long() global varia...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/696
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/74/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #696: TS-3245: Made changes based on input from James Pe...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/696
Can we change the Subject line of this to describe what this fixes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---