You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Erick Erickson (JIRA)" <ji...@apache.org> on 2013/03/24 19:11:15 UTC
[jira] [Updated] (SOLR-4615) Take out the possibility of having a
solr.properties file
[ https://issues.apache.org/jira/browse/SOLR-4615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erick Erickson updated SOLR-4615:
---------------------------------
Attachment: SOLR-4615.patch
I had a long plane ride so I cut solr.properties out in the attached patch. All tests pass, although I haven't yet really gone over it yet, consider this preliminary.
Known tasks not yet done:
1> add tests for persisting the new property.
2> there are a couple of JIRAs (SOLR-4631 and SOLR-4632) that I have yet to incorporate.
There is a new attribute for <cores>, autoDiscoverCores=["true"|"false"], defaults presently to "false". If you'd like a different name, speak now...
I left the interface definition in place, currently only ConfigSolrXml implements it (renamed from ConfigSolrXmlBackCompat). My theory is that since it's there already, leaving it in has the advantage of allowing easier implementation of a pluggable configuration provider of some kind should the desire arise. One possibility (although I know _nothing_ about whether it's desirable) would be provide all this info from ZK directly, maybe based on a sysprop?
I also renamed several files, removed the supporting config fies for solr.properties etc., so be aware that some things have moved around...
I plan to commit this in the next couple of days to both trunk and 4x on the theory that the faster I take solr.properties out of code anyone can get to, the less they'll be inconvenienced by flip-flopping.
Changing this didn't require any changes to the tricky bits around coordinating core load/unload/reload code, so it's not a radical change. Not to say I necessarily did it right, but it's not nearly as scary as the rest of the changes for SOLR-4196.
All comments welcome....
> Take out the possibility of having a solr.properties file
> ---------------------------------------------------------
>
> Key: SOLR-4615
> URL: https://issues.apache.org/jira/browse/SOLR-4615
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.3, 5.0
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Attachments: SOLR-4615.patch
>
>
> We seem to have re-thought whether deprecating Solr.xml is The Right Thing To Do or not, the consensus seems to be that we should keep solr.xml, _not_ be able to specify solr.properties but add an attribute to the <cores> tag in solr.xml, tentatively called autoDiscover=true|false (assume false for 4.x, true for 5.0?)
> This really has to be done before 4.3 is cut, as in Real Soon Now.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org