[GitHub] [spark] panbingkun commented on a diff in pull request #42797: [SPARK-45068][SQL] Make function output column name consistent in case

["panbingkun (via GitHub)" <gi...@apache.org>]

panbingkun commented on code in PR #42797:
URL: https://github.com/apache/spark/pull/42797#discussion_r1315497780


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala:
##########
@@ -67,7 +67,8 @@ abstract class UnaryMathExpression(val f: Double => Double, name: String)
   override def dataType: DataType = DoubleType
   override def nullable: Boolean = true
   override def toString: String = s"$prettyName($child)"
-  override def prettyName: String = getTagValue(FunctionRegistry.FUNC_ALIAS).getOrElse(name)
+  override def prettyName: String = getTagValue(FunctionRegistry.FUNC_ALIAS).
+    getOrElse(name.toLowerCase(Locale.ROOT))

Review Comment:
   Okay, let me also change LeafMathExpression together. Originally, I thought the subclasses of LeafMathExpression: E and PI to be displayed in uppercase, which may be a better choice.
   Let me to do it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org