[GitHub] [spark] srowen commented on a change in pull request #31170: [SPARK-33245][SQL] Add built-in UDF - GETBIT

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #31170:
URL: https://github.com/apache/spark/pull/31170#discussion_r557467235



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##########
@@ -550,6 +550,8 @@ object FunctionRegistry {
     expression[BitAndAgg]("bit_and"),
     expression[BitOrAgg]("bit_or"),
     expression[BitXorAgg]("bit_xor"),
+    expression[BitwiseGet]("bit_get"),

Review comment:
       I assume the point is to add functions that other DBs have - this seems pretty niche. If so, it needs to be `getbit` no? how commonly used is this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org