[GitHub] [pinot] mingmxu commented on a diff in pull request #10943: [#10884][feature] add requestId for BrokerResponse in pinot-broker and java-client

["mingmxu (via GitHub)" <gi...@apache.org>]

mingmxu commented on code in PR #10943:
URL: https://github.com/apache/pinot/pull/10943#discussion_r1239291556


##########
pinot-common/src/main/java/org/apache/pinot/common/response/broker/BrokerResponseStats.java:
##########
@@ -33,7 +33,7 @@
 //  same metadataKey
 // TODO: Replace member fields with a simple map of <MetadataKey, Object>
 // TODO: Add a subStat field, stage level subStats will contain each operator stats
-@JsonPropertyOrder({"exceptions", "numBlocks", "numRows", "stageExecutionTimeMs", "stageExecutionUnit",
+@JsonPropertyOrder({"requestId", "exceptions", "numBlocks", "numRows", "stageExecutionTimeMs", "stageExecutionUnit",

Review Comment:
   Yeah that's a problem, I'll submit another PR to reuse `MultiStageRequestIdGenerator` in v1 engine. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org