You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/05/18 02:25:21 UTC
[kudu-CR] [kserver] output info on server-wide size limit
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17474
Change subject: [kserver] output info on server-wide size limit
......................................................................
[kserver] output info on server-wide size limit
With this patch, Kudu servers output an INFO log line about the maximum
number of threads in a server-wide thread pool. That's useful when
assessing how many threads a Kudu server might legitimately spawn.
Yes, those numbers can be calculated given the setting for RLIMIT_NPROC
and values in /proc/sys/kernel/pid_max and /proc/sys/kernel/threads-max,
but (a) those settings might change after the start of a server and
(b) it's convenient to have a pre-computed number ready in the logs.
Change-Id: I62b4168fc153e693f0fcc3d6d1ecfc6be0e69b47
---
M src/kudu/kserver/kserver.cc
1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/17474/1
--
To view, visit http://gerrit.cloudera.org:8080/17474
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I62b4168fc153e693f0fcc3d6d1ecfc6be0e69b47
Gerrit-Change-Number: 17474
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [kserver] output info on server-wide size limit
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17474 )
Change subject: [kserver] output info on server-wide size limit
......................................................................
[kserver] output info on server-wide size limit
With this patch, Kudu servers output an INFO log line about the maximum
number of threads in a server-wide thread pool. That's useful when
assessing how many threads a Kudu server might legitimately spawn.
Yes, those numbers can be calculated given the setting for RLIMIT_NPROC
and values in /proc/sys/kernel/pid_max and /proc/sys/kernel/threads-max,
but (a) those settings might change after the start of a server and
(b) it's convenient to have a pre-computed number ready in the logs.
Change-Id: I62b4168fc153e693f0fcc3d6d1ecfc6be0e69b47
Reviewed-on: http://gerrit.cloudera.org:8080/17474
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/kserver/kserver.cc
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Bankim Bhavsar: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17474
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I62b4168fc153e693f0fcc3d6d1ecfc6be0e69b47
Gerrit-Change-Number: 17474
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [kserver] output info on server-wide size limit
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17474 )
Change subject: [kserver] output info on server-wide size limit
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17474/1/src/kudu/kserver/kserver.cc
File src/kudu/kserver/kserver.cc:
http://gerrit.cloudera.org:8080/#/c/17474/1/src/kudu/kserver/kserver.cc@163
PS1, Line 163: s
> Nit: Server-wide?
Done
--
To view, visit http://gerrit.cloudera.org:8080/17474
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62b4168fc153e693f0fcc3d6d1ecfc6be0e69b47
Gerrit-Change-Number: 17474
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 18 May 2021 17:13:40 +0000
Gerrit-HasComments: Yes
[kudu-CR] [kserver] output info on server-wide size limit
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17474
to look at the new patch set (#2).
Change subject: [kserver] output info on server-wide size limit
......................................................................
[kserver] output info on server-wide size limit
With this patch, Kudu servers output an INFO log line about the maximum
number of threads in a server-wide thread pool. That's useful when
assessing how many threads a Kudu server might legitimately spawn.
Yes, those numbers can be calculated given the setting for RLIMIT_NPROC
and values in /proc/sys/kernel/pid_max and /proc/sys/kernel/threads-max,
but (a) those settings might change after the start of a server and
(b) it's convenient to have a pre-computed number ready in the logs.
Change-Id: I62b4168fc153e693f0fcc3d6d1ecfc6be0e69b47
---
M src/kudu/kserver/kserver.cc
1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/17474/2
--
To view, visit http://gerrit.cloudera.org:8080/17474
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I62b4168fc153e693f0fcc3d6d1ecfc6be0e69b47
Gerrit-Change-Number: 17474
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [kserver] output info on server-wide size limit
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17474 )
Change subject: [kserver] output info on server-wide size limit
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17474
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62b4168fc153e693f0fcc3d6d1ecfc6be0e69b47
Gerrit-Change-Number: 17474
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 18 May 2021 17:27:26 +0000
Gerrit-HasComments: No
[kudu-CR] [kserver] output info on server-wide size limit
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17474 )
Change subject: [kserver] output info on server-wide size limit
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17474/1/src/kudu/kserver/kserver.cc
File src/kudu/kserver/kserver.cc:
http://gerrit.cloudera.org:8080/#/c/17474/1/src/kudu/kserver/kserver.cc@163
PS1, Line 163: s
Nit: Server-wide?
--
To view, visit http://gerrit.cloudera.org:8080/17474
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62b4168fc153e693f0fcc3d6d1ecfc6be0e69b47
Gerrit-Change-Number: 17474
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 18 May 2021 15:55:14 +0000
Gerrit-HasComments: Yes
[kudu-CR] [kserver] output info on server-wide size limit
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17474 )
Change subject: [kserver] output info on server-wide size limit
......................................................................
Patch Set 2: Verified+1
unrelated test failure in BlockManagerType/TsRecoveryITest.TestRestartWithOrphanedReplicates/0
--
To view, visit http://gerrit.cloudera.org:8080/17474
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62b4168fc153e693f0fcc3d6d1ecfc6be0e69b47
Gerrit-Change-Number: 17474
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 18 May 2021 18:33:33 +0000
Gerrit-HasComments: No
[kudu-CR] [kserver] output info on server-wide size limit
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [kserver] output info on server-wide size limit
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17474
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I62b4168fc153e693f0fcc3d6d1ecfc6be0e69b47
Gerrit-Change-Number: 17474
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)