[GitHub] [druid] jihoonson commented on a change in pull request #9076: variance aggregator support for double columns

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #9076: variance aggregator support for double columns
URL: https://github.com/apache/druid/pull/9076#discussion_r378020369
 
 

 ##########
 File path: extensions-core/stats/src/main/java/org/apache/druid/query/aggregation/variance/VarianceAggregatorFactory.java
 ##########
 @@ -304,4 +314,19 @@ public int hashCode()
 
     return Objects.hash(fieldName, name, estimator, inputType, isVariancePop);
   }
+
+  private String getTypeString(ColumnSelectorFactory metricFactory)
+  {
+    String type = inputType;
+    if (type == null) {
+      ColumnCapabilities capabilities = metricFactory.getColumnCapabilities(fieldName);
+      if (capabilities != null) {
+        type = StringUtils.toLowerCase(capabilities.getType().name());
+      } else {
+        type = "float";
 
 Review comment:
   nit: may be worth to be a static variable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org