[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #3078: feat(services/s3): Rewrite the method signatures using OpWrite

["Xuanwo (via GitHub)" <gi...@apache.org>]

Xuanwo commented on code in PR #3078:
URL: https://github.com/apache/incubator-opendal/pull/3078#discussion_r1326699517


##########
core/src/services/s3/core.rs:
##########
@@ -517,25 +515,23 @@ impl S3Core {
     pub async fn s3_initiate_multipart_upload(
         &self,
         path: &str,
-        content_type: Option<&str>,
-        content_disposition: Option<&str>,
-        cache_control: Option<&str>,
+        args: &OpWrite,

Review Comment:
   Hi, please also check the place where uses those functions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org