You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by baishuo <gi...@git.apache.org> on 2014/03/26 17:05:07 UTC
[GitHub] spark pull request: Update slaves.sh
GitHub user baishuo opened a pull request:
https://github.com/apache/spark/pull/238
Update slaves.sh
update the comment
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/baishuo/spark patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/238.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #238
----
commit 0f08299625bf6135365e8127cb6cfbca2162c909
Author: baishuo(白硕) <vc...@hotmail.com>
Date: 2014-03-26T16:03:45Z
Update slaves.sh
update the comment
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update slaves.sh
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/238#discussion_r10985732
--- Diff: sbin/slaves.sh ---
@@ -43,7 +43,7 @@ sbin=`cd "$sbin"; pwd`
# If the slaves file is specified in the command line,
# then it takes precedence over the definition in
-# spark-env.sh. Save it here.
+# load-spark-env.sh. Save it here.
--- End diff --
I'm not sure this change is correct. We still want users defining variables inside of `spark-env.sh` right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update slaves.sh
Posted by baishuo <gi...@git.apache.org>.
Github user baishuo commented on the pull request:
https://github.com/apache/spark/pull/238#issuecomment-38713391
yeah ,get it. thank you@ppwendell. close it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update slaves.sh
Posted by baishuo <gi...@git.apache.org>.
Github user baishuo closed the pull request at:
https://github.com/apache/spark/pull/238
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Update slaves.sh
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/238#issuecomment-38704046
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---