You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Andreas Goss (Jira)" <ji...@apache.org> on 2023/01/30 17:34:00 UTC

[jira] [Commented] (GEOMETRY-144) Review API in "hull" module

    [ https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682200#comment-17682200 ] 

Andreas Goss commented on GEOMETRY-144:
---------------------------------------

Is there really a need for a ConvexHull interface as there is right now in the hull module? As i see it the interface offers little additional functionality compared to the ConvexArea and ConvexVolume class (keeps only track of the vertices). Every ConvexVolume is constructed as the intersection of all the negative half-space of the provided Planes. So in essence the constructed Volume is exactly the convex hull of all the intersection point of said planes. It would make sense to offer the functionality of any hull algorithms through static factory methods in ConvexArea and ConvexVolume in my mind. In this way all the complexity of the algorithm is hidden by those classes and there is no need for an additional type. 

> Review API in "hull" module
> ---------------------------
>
>                 Key: GEOMETRY-144
>                 URL: https://issues.apache.org/jira/browse/GEOMETRY-144
>             Project: Commons Geometry
>          Issue Type: Task
>            Reporter: Gilles Sadowski
>            Assignee: Gilles Sadowski
>            Priority: Minor
>             Fix For: 1.1
>
>
> Review codes in the [{{commons-geometry-hull}}|https://gitbox.apache.org/repos/asf?p=commons-geometry.git;a=tree;f=commons-geometry-hull;hb=HEAD] module.
> (x) Minimize the public API



--
This message was sent by Atlassian Jira
(v8.20.10#820010)