You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2019/11/23 21:04:00 UTC

[GitHub] [groovy] eric-milles edited a comment on issue #1103: GROOVY-9315: Bump bytecode version to 1.8

eric-milles edited a comment on issue #1103: GROOVY-9315: Bump bytecode version to 1.8
URL: https://github.com/apache/groovy/pull/1103#issuecomment-557832457
 
 
   So, I tried to keep from having extra constants added to CompilerConfiguration and now there are 3.  What is the purpose of `ASM_API_VERSION`, `ASM_COMPUTE_MODE` and `ASM_PARSE_MODE`?  Who would use them (that is whay are they in CompilerConfiguration and public)?  What is the new `CompilerConfiguration#getAsmTargetBytecode` for and why is it separate from `getTargetBytecode`?
   
   I don't understand the motivation of all of these changes and there are now 18 files changed and a whole bunch of commits.  The issue just says "bump bytecode version".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services