You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/07/27 20:45:32 UTC

[GitHub] [zeppelin] vjr opened a new pull request, #4436: [ZEPPELIN-5789] Update Dockerfile to use JDK instead of JRE

vjr opened a new pull request, #4436:
URL: https://github.com/apache/zeppelin/pull/4436

   ### What is this PR for?
   Fixes issues such as trying to add a new interpreter belonging to "jdbc" group having hive-jdbc conf results in missing dependencies (tools.jar) and such.
   
   ### What type of PR is it?
   Bug Fix
   
   ### Todos
   (none)
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/ZEPPELIN-5789
   
   ### How should this be tested?
   Build, publish and run the image via Dockerfile `docker run -d -p 80:8080 --name test imagename`
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need to update? NO
   * Is there breaking changes for older versions? NO
   * Does this needs documentation? NO
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] jongyoul commented on pull request #4436: [ZEPPELIN-5789] Update Dockerfile to use JDK instead of JRE

Posted by GitBox <gi...@apache.org>.
jongyoul commented on PR #4436:
URL: https://github.com/apache/zeppelin/pull/4436#issuecomment-1197649626

   Thank you for your contribution. :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] jongyoul merged pull request #4436: [ZEPPELIN-5789] Update Dockerfile to use JDK instead of JRE

Posted by GitBox <gi...@apache.org>.
jongyoul merged PR #4436:
URL: https://github.com/apache/zeppelin/pull/4436


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] vjr commented on pull request #4436: [ZEPPELIN-5789] Update Dockerfile to use JDK instead of JRE

Posted by GitBox <gi...@apache.org>.
vjr commented on PR #4436:
URL: https://github.com/apache/zeppelin/pull/4436#issuecomment-1197781754

   Agreed , although I propose to have this pr merged as interim fix until Zeppelin itself moves to newer JDK version, is this okay?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] vjr commented on pull request #4436: [ZEPPELIN-5789] Update Dockerfile to use JDK instead of JRE

Posted by GitBox <gi...@apache.org>.
vjr commented on PR #4436:
URL: https://github.com/apache/zeppelin/pull/4436#issuecomment-1197987164

   > Please add a comment. When we upgrade to > jdk8, we should switch back to jre.
   
   Done.
   
   I was only able to set the target version to 0.11 in Jira... Is there a way to request inclusion in any further 0.10.x release if it happens? Or I presume that will happen by default if this PR gets merged?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #4436: [ZEPPELIN-5789] Update Dockerfile to use JDK instead of JRE

Posted by GitBox <gi...@apache.org>.
Reamer commented on PR #4436:
URL: https://github.com/apache/zeppelin/pull/4436#issuecomment-1199212303

   > I was only able to set the target version to 0.11 in Jira... Is there a way to request inclusion in any further 0.10.x release if it happens? Or I presume that will happen by default if this PR gets merged?
   
   The merger can backport this small change to branch-0.10.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #4436: [ZEPPELIN-5789] Update Dockerfile to use JDK instead of JRE

Posted by GitBox <gi...@apache.org>.
Reamer commented on PR #4436:
URL: https://github.com/apache/zeppelin/pull/4436#issuecomment-1197727478

   `tools.jar` should not be used any further. In JDK 9 `tools.jar` and `rt.jar` was even removed from the JDK.
   We should better raise the dependency that `tools.jar` needs during runtime. Take a look at https://openjdk.org/jeps/220


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #4436: [ZEPPELIN-5789] Update Dockerfile to use JDK instead of JRE

Posted by GitBox <gi...@apache.org>.
Reamer commented on PR #4436:
URL: https://github.com/apache/zeppelin/pull/4436#issuecomment-1197914197

   Please add a comment. When we upgrade to > jdk8, we should switch back to jre.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org