[GitHub] [skywalking-banyandb-java-client] lujiajing1126 commented on a diff in pull request #30: Remove Measure ID

[GitBox <gi...@apache.org>]

lujiajing1126 commented on code in PR #30:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/30#discussion_r1061417211


##########
src/main/java/org/apache/skywalking/banyandb/v1/client/MeasureWrite.java:
##########
@@ -52,10 +51,6 @@ public MeasureWrite tag(String tagName, Serializable<BanyandbModel.TagValue> tag
         return (MeasureWrite) super.tag(tagName, tagValue);
     }
 
-    public MeasureWrite setID(String idValue) throws BanyanDBException {
-        return this.tag(Measure.ID, TagAndValue.idTagValue(idValue));

Review Comment:
   Shall we remove ID type completely?



##########
src/main/java/org/apache/skywalking/banyandb/v1/client/Element.java:
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.banyandb.v1.client;
+
+import lombok.Getter;
+import org.apache.skywalking.banyandb.stream.v1.BanyandbStream;
+
+/**
+ * RowEntity represents an entity of BanyanDB entity.
+ */
+@Getter
+public class Element extends RowEntity {
+    /**
+     * identity of the element.
+     * For a trace entity, it is the spanID of a Span or the segmentId of a segment in Skywalking,
+     */
+    protected String id;

Review Comment:
   final?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org