[GitHub] [kafka] mnegodaev commented on a diff in pull request #11442: KAFKA-7883 add schema.namespace support to SetSchemaMetadata SMT in Kafka Connect

[GitBox <gi...@apache.org>]

mnegodaev commented on code in PR #11442:
URL: https://github.com/apache/kafka/pull/11442#discussion_r942707777


##########
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/SetSchemaMetadata.java:
##########
@@ -71,7 +78,7 @@ public R apply(R record) {
                 schema.type(),
                 schema.isOptional(),
                 schema.defaultValue(),
-                schemaName != null ? schemaName : schema.name(),
+                buildSchemaName(schemaNamespace, schemaName != null ? schemaName : schema.name()),

Review Comment:
   @daehokimm, thank for your review, I guess [this parameterized unit-test](https://github.com/apache/kafka/pull/11442/files#diff-8470d18c341b6c20f7a6751d2f42af43560525bfeca29bd980ec29d256153205R77) should answer your question.
   The case with just namespace set and an empty schema Name is acceptable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org