[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2261: HDDS-5243. Return latest key location for clients

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #2261:
URL: https://github.com/apache/ozone/pull/2261#discussion_r635196241



##########
File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##########
@@ -1148,6 +1155,7 @@ public OzoneInputStream readFile(String volumeName, String bucketName,
         .setBucketName(bucketName)
         .setKeyName(keyName)
         .setSortDatanodesInPipeline(topologyAwareReadEnabled)
+        .setFullLocationVersion(getFullLocationVersion)

Review comment:
       Do you think we need to use this in listStatus also?

##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##########
@@ -679,6 +679,10 @@ public OmKeyInfo lookupKey(OmKeyArgs args, String clientAddress)
       throw new OMException("Key not found", KEY_NOT_FOUND);
     }
 
+    if (!args.getFullLocationVersion()) {

Review comment:
       This flag is set in lookupFile, getFileStatus, readKey/readFile in RpcClient but on Server, I don't see any use of that.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org