You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/10/09 02:29:47 UTC
Review Request 26470: Removed unused resources and duplicated
attributes from Slave.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26470/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos-git
Description
-------
See summary. Right now, the 'resources' obtained from localhost:5051/state.json is not correct.
Diffs
-----
src/slave/http.cpp ec7c6b992f72246db0044734785c4d851a27734a
src/slave/slave.hpp 28697102047b972ecb3b6b627ee089b430549fc0
src/slave/slave.cpp 809b008b1502b80cce4d8b4be0a233117c92ed56
Diff: https://reviews.apache.org/r/26470/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 26470: Removed unused resources and duplicated
attributes from Slave.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26470/#review56212
-----------------------------------------------------------
Ship it!
src/tests/slave_tests.cpp
<https://reviews.apache.org/r/26470/#comment96535>
s/get("")/get()/ ?
- Ben Mahler
On Oct. 10, 2014, 7:41 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26470/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2014, 7:41 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary. Right now, the 'resources' obtained from localhost:5051/state.json is not correct.
>
>
> Diffs
> -----
>
> src/slave/http.cpp ec7c6b992f72246db0044734785c4d851a27734a
> src/slave/slave.hpp 76d505c698774204b2536b66ea8a83a9a2a5e2c1
> src/slave/slave.cpp cb3759993f863590cb1545c73072feb0331aa6c9
> src/tests/slave_tests.cpp 69be28f6e82b99e23424bd2be8294f715d8040d4
>
> Diff: https://reviews.apache.org/r/26470/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 26470: Removed unused resources and duplicated
attributes from Slave.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26470/
-----------------------------------------------------------
(Updated Oct. 10, 2014, 7:41 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Added a test.
Repository: mesos-git
Description
-------
See summary. Right now, the 'resources' obtained from localhost:5051/state.json is not correct.
Diffs (updated)
-----
src/slave/http.cpp ec7c6b992f72246db0044734785c4d851a27734a
src/slave/slave.hpp 76d505c698774204b2536b66ea8a83a9a2a5e2c1
src/slave/slave.cpp cb3759993f863590cb1545c73072feb0331aa6c9
src/tests/slave_tests.cpp 69be28f6e82b99e23424bd2be8294f715d8040d4
Diff: https://reviews.apache.org/r/26470/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 26470: Removed unused resources and duplicated
attributes from Slave.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26470/#review55929
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26470]
All tests passed.
- Mesos ReviewBot
On Oct. 9, 2014, 12:29 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26470/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2014, 12:29 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary. Right now, the 'resources' obtained from localhost:5051/state.json is not correct.
>
>
> Diffs
> -----
>
> src/slave/http.cpp ec7c6b992f72246db0044734785c4d851a27734a
> src/slave/slave.hpp 28697102047b972ecb3b6b627ee089b430549fc0
> src/slave/slave.cpp 809b008b1502b80cce4d8b4be0a233117c92ed56
>
> Diff: https://reviews.apache.org/r/26470/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 26470: Removed unused resources and duplicated
attributes from Slave.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26470/#review56193
-----------------------------------------------------------
Ship it!
Feel free to add tests in a separate review, this looks right but would be great to at least verify manually before you commit this.
- Ben Mahler
On Oct. 9, 2014, 12:29 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26470/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2014, 12:29 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary. Right now, the 'resources' obtained from localhost:5051/state.json is not correct.
>
>
> Diffs
> -----
>
> src/slave/http.cpp ec7c6b992f72246db0044734785c4d851a27734a
> src/slave/slave.hpp 28697102047b972ecb3b6b627ee089b430549fc0
> src/slave/slave.cpp 809b008b1502b80cce4d8b4be0a233117c92ed56
>
> Diff: https://reviews.apache.org/r/26470/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 26470: Removed unused resources and duplicated
attributes from Slave.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26470/#review55920
-----------------------------------------------------------
Should probably file a ticket for the state.json inaccuracy?
A test would be nice if you're feeling up for it! :)
- Ben Mahler
On Oct. 9, 2014, 12:29 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26470/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2014, 12:29 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary. Right now, the 'resources' obtained from localhost:5051/state.json is not correct.
>
>
> Diffs
> -----
>
> src/slave/http.cpp ec7c6b992f72246db0044734785c4d851a27734a
> src/slave/slave.hpp 28697102047b972ecb3b6b627ee089b430549fc0
> src/slave/slave.cpp 809b008b1502b80cce4d8b4be0a233117c92ed56
>
> Diff: https://reviews.apache.org/r/26470/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>