You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by GitBox <gi...@apache.org> on 2022/12/13 15:05:39 UTC

[GitHub] [ofbiz-framework] danwatford opened a new pull request, #569: Improved: Removed unused oldQOH and oldATP fields from InventoryItem (OFBIZ-12723)

danwatford opened a new pull request, #569:
URL: https://github.com/apache/ofbiz-framework/pull/569

   Fields were used to migrate QOH and ATP inventory values to InventoryItemDetails entities following data model changes prior to June 2006 are are no longer needed. Similarly, services which performed the migration have also been removed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improved: Removed unused oldQOH and oldATP fields from InventoryItem (OFBIZ-12723) [ofbiz-framework]

Posted by "PierreSmits (via GitHub)" <gi...@apache.org>.
PierreSmits commented on PR #569:
URL: https://github.com/apache/ofbiz-framework/pull/569#issuecomment-1966627256

   Apparently, @dixitdeepak didn't experience any issues when he deleted the branch re  OFBIZ-12812


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improved: Removed unused oldQOH and oldATP fields from InventoryItem (OFBIZ-12723) [ofbiz-framework]

Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux commented on PR #569:
URL: https://github.com/apache/ofbiz-framework/pull/569#issuecomment-1966931877

   Mmm, actually I'm not quite sure of the time between the 3 removings and restaurations. And maybe it was only a quirk then.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improved: Removed unused oldQOH and oldATP fields from InventoryItem (OFBIZ-12723) [ofbiz-framework]

Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux commented on PR #569:
URL: https://github.com/apache/ofbiz-framework/pull/569#issuecomment-1966595574

   OK thanks, let's wait another such case before asking ;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] danwatford merged pull request #569: Improved: Removed unused oldQOH and oldATP fields from InventoryItem (OFBIZ-12723)

Posted by GitBox <gi...@apache.org>.
danwatford merged PR #569:
URL: https://github.com/apache/ofbiz-framework/pull/569


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improved: Removed unused oldQOH and oldATP fields from InventoryItem (OFBIZ-12723) [ofbiz-framework]

Posted by "danwatford (via GitHub)" <gi...@apache.org>.
danwatford commented on PR #569:
URL: https://github.com/apache/ofbiz-framework/pull/569#issuecomment-1966476589

   I didn't do anything deliberate to restore the branch. If it gets restored again by asfgit we can ask infra to advise. Perhaps we have to remove it in both the GitHub and ASF repositories.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #569: Improved: Removed unused oldQOH and oldATP fields from InventoryItem (OFBIZ-12723)

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #569:
URL: https://github.com/apache/ofbiz-framework/pull/569#issuecomment-1348764654

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=569)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=569&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=569&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=569&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=569&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=569&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=569&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=569&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=569&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=569&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=569&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=569&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=569&resolved=false&types=CODE_SMELL)
   
   [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=569) No Coverage information  
   [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=569&metric=duplicated_lines_density&view=list) No Duplication information
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improved: Removed unused oldQOH and oldATP fields from InventoryItem (OFBIZ-12723) [ofbiz-framework]

Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux commented on PR #569:
URL: https://github.com/apache/ofbiz-framework/pull/569#issuecomment-1966914380

   Pierre, was this recent? Because here there have been months between the 3 situations. BTW I see a "Restore branch" button at right of last removing reference. Anyway let's see...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improved: Removed unused oldQOH and oldATP fields from InventoryItem (OFBIZ-12723) [ofbiz-framework]

Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux commented on PR #569:
URL: https://github.com/apache/ofbiz-framework/pull/569#issuecomment-1966464720

   It's weird, why asfgit did restore twice this branch? Or is it someone hidden behind (w/o wanted to be hidden I guess)? Maybe you Daniel?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org