[GitHub] [wicket] martin-g commented on a diff in pull request #565: [WICKET-6915] Fileupload2 is copied to wicket

["martin-g (via GitHub)" <gi...@apache.org>]

martin-g commented on code in PR #565:
URL: https://github.com/apache/wicket/pull/565#discussion_r1149143654


##########
wicket-commons-fileupload/src/test/java/org/apache/wicket/commons/fileupload2/util/mime/Base64DecoderTestCase.java:
##########
@@ -0,0 +1,165 @@
+/*

Review Comment:
   I am not sure whether Wicket's surefire setup will run `**TestCase` named classes.



##########
wicket-extensions/src/main/java/module-info.java:
##########
@@ -21,7 +21,8 @@
     requires org.slf4j;
     requires com.fasterxml.jackson.databind;
     requires com.github.openjson;
-    requires commons.fileupload2;
+    //commented out due to local-copy WICKET-6915 requires commons.fileupload2;

Review Comment:
   ditto



##########
wicket-core/src/main/java/module-info.java:
##########
@@ -23,7 +23,8 @@
     requires org.apache.wicket.request;
     requires org.apache.commons.io;
     requires org.apache.commons.collections4;
-    requires commons.fileupload2;
+    //commented out due to local-copy WICKET-6915 requires commons.fileupload2;

Review Comment:
   it is not commented out but replaced.
   IMO the comment could be removed



##########
wicket-util/src/main/java/module-info.java:
##########
@@ -23,7 +23,8 @@
     requires java.desktop;
     requires org.apache.commons.io;
     requires org.apache.commons.collections4;
-    requires commons.fileupload2;
+    //commented out due to local-copy WICKET-6915 requires commons.fileupload2;

Review Comment:
   ditto



##########
wicket-util/pom.xml:
##########
@@ -40,9 +40,14 @@
 			<groupId>org.apache.commons</groupId>
 			<artifactId>commons-collections4</artifactId>
 		</dependency>
+		<!-- Commented out due to all classes are copied into wicket-commons-fileupload
 		<dependency>
 			<groupId>org.apache.commons</groupId>
 			<artifactId>commons-fileupload2</artifactId>
+		</dependency-->
+		<dependency>
+			<groupId>org.apache.wicket</groupId>
+			<artifactId>wicket-commons-fileupload</artifactId>

Review Comment:
   Since we have the dependency here I think there is no need to have it in wicket-core too. It will come as a transitive one



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org