You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/12/23 05:14:45 UTC
[Impala-ASF-CR] IMPALA-10117: Skip calls to FsPermissionCache for blob stores
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16898
Change subject: IMPALA-10117: Skip calls to FsPermissionCache for blob stores
......................................................................
IMPALA-10117: Skip calls to FsPermissionCache for blob stores
This avoids calling precacheChildrenOf() in cases when the
cached values will never be used. This change simply skips
calling precacheChildrenOf() in the cases when getPermissions()
is never called.
There is some opportunity to clean up this permissions
checking further, but I decided to keep this fix limited
in scope.
Change-Id: I2034695a956307309f656d56aa57aa07ae5163d8
---
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
1 file changed, 27 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/16898/1
--
To view, visit http://gerrit.cloudera.org:8080/16898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2034695a956307309f656d56aa57aa07ae5163d8
Gerrit-Change-Number: 16898
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10117: Skip calls to FsPermissionCache for blob stores
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16898 )
Change subject: IMPALA-10117: Skip calls to FsPermissionCache for blob stores
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2034695a956307309f656d56aa57aa07ae5163d8
Gerrit-Change-Number: 16898
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Dec 2020 07:06:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10117: Skip calls to FsPermissionCache for blob stores
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16898 )
Change subject: IMPALA-10117: Skip calls to FsPermissionCache for blob stores
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7900/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2034695a956307309f656d56aa57aa07ae5163d8
Gerrit-Change-Number: 16898
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Dec 2020 05:36:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10117: Skip calls to FsPermissionCache for blob stores
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16898 )
Change subject: IMPALA-10117: Skip calls to FsPermissionCache for blob stores
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2034695a956307309f656d56aa57aa07ae5163d8
Gerrit-Change-Number: 16898
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Dec 2020 01:32:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10117: Skip calls to FsPermissionCache for blob stores
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16898 )
Change subject: IMPALA-10117: Skip calls to FsPermissionCache for blob stores
......................................................................
Patch Set 1: Code-Review+2
Thanks for catching up this!
--
To view, visit http://gerrit.cloudera.org:8080/16898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2034695a956307309f656d56aa57aa07ae5163d8
Gerrit-Change-Number: 16898
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Dec 2020 01:31:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10117: Skip calls to FsPermissionCache for blob stores
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16898 )
Change subject: IMPALA-10117: Skip calls to FsPermissionCache for blob stores
......................................................................
IMPALA-10117: Skip calls to FsPermissionCache for blob stores
This avoids calling precacheChildrenOf() in cases when the
cached values will never be used. This change simply skips
calling precacheChildrenOf() in the cases when getPermissions()
is never called.
There is some opportunity to clean up this permissions
checking further, but I decided to keep this fix limited
in scope.
Change-Id: I2034695a956307309f656d56aa57aa07ae5163d8
Reviewed-on: http://gerrit.cloudera.org:8080/16898
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
1 file changed, 27 insertions(+), 14 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2034695a956307309f656d56aa57aa07ae5163d8
Gerrit-Change-Number: 16898
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10117: Skip calls to FsPermissionCache for blob stores
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16898 )
Change subject: IMPALA-10117: Skip calls to FsPermissionCache for blob stores
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6806/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2034695a956307309f656d56aa57aa07ae5163d8
Gerrit-Change-Number: 16898
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Dec 2020 01:32:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10117: Skip calls to FsPermissionCache for blob stores
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16898 )
Change subject: IMPALA-10117: Skip calls to FsPermissionCache for blob stores
......................................................................
Patch Set 1:
I noticed the JIRA from Sahil and figured it was an easy fix to speed up table loading.
--
To view, visit http://gerrit.cloudera.org:8080/16898
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2034695a956307309f656d56aa57aa07ae5163d8
Gerrit-Change-Number: 16898
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Dec 2020 05:15:34 +0000
Gerrit-HasComments: No