You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:36:16 UTC

[GitHub] [incubator-superset] lilykuang commented on a change in pull request #10444: feat: dataset editor improvement

lilykuang commented on a change in pull request #10444:
URL: https://github.com/apache/incubator-superset/pull/10444#discussion_r461760694



##########
File path: superset-frontend/src/datasource/DatasourceEditor.jsx
##########
@@ -83,18 +83,23 @@ function ColumnCollectionTable({
               <Field
                 fieldKey="expression"
                 label={t('SQL Expression')}
-                control={<TextControl />}
+                control={
+                  <TextAreaControl

Review comment:
       update the sql expression field to half the size 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org