You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Gary Dusbabek (JIRA)" <ji...@apache.org> on 2010/08/19 22:50:16 UTC

[jira] Created: (CASSANDRA-1411) FBUtilities.hexToBytes() doesn't accommodate odd-length strings.

FBUtilities.hexToBytes() doesn't accommodate odd-length strings.
----------------------------------------------------------------

                 Key: CASSANDRA-1411
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1411
             Project: Cassandra
          Issue Type: Bug
          Components: Core
    Affects Versions: 0.6.4
            Reporter: Gary Dusbabek
            Assignee: Gary Dusbabek
            Priority: Minor
             Fix For: 0.7 beta 2


This is a problem when a user specifies ByteOrderedPartitioner with an odd-length initial token (like "0").

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1411) FBUtilities.hexToBytes() doesn't accommodate odd-length strings.

Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900452#action_12900452 ] 

Jon Hermes commented on CASSANDRA-1411:
---------------------------------------

+1 anti-annoyance patch.

> FBUtilities.hexToBytes() doesn't accommodate odd-length strings.
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-1411
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1411
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.6.4
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7 beta 2
>
>         Attachments: v1-0001-FBUtilities.hexToBytes-doesn-t-handle-odd-length-strin.txt
>
>
> This is a problem when a user specifies ByteOrderedPartitioner with an odd-length initial token (like "0").

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1411) FBUtilities.hexToBytes() doesn't accommodate odd-length strings.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901011#action_12901011 ] 

Hudson commented on CASSANDRA-1411:
-----------------------------------

Integrated in Cassandra #518 (See [https://hudson.apache.org/hudson/job/Cassandra/518/])
    FBUtilities.hexToBytes doesn't handle odd-length strings. patch by Gary Dusbabek, reviewed by Jon Hermes. CASSANDRA-1411


> FBUtilities.hexToBytes() doesn't accommodate odd-length strings.
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-1411
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1411
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.6.4
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7 beta 2
>
>         Attachments: v1-0001-FBUtilities.hexToBytes-doesn-t-handle-odd-length-strin.txt
>
>
> This is a problem when a user specifies ByteOrderedPartitioner with an odd-length initial token (like "0").

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1411) FBUtilities.hexToBytes() doesn't accommodate odd-length strings.

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900750#action_12900750 ] 

Gary Dusbabek commented on CASSANDRA-1411:
------------------------------------------

Erroring on odd-lengthed, yet still valid hex values is neither pragmatic or very useful.  hex 0 is dec 0, hex 101 is dec 257, so is hex 0101; let's just handle them.

> FBUtilities.hexToBytes() doesn't accommodate odd-length strings.
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-1411
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1411
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.6.4
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7 beta 2
>
>         Attachments: v1-0001-FBUtilities.hexToBytes-doesn-t-handle-odd-length-strin.txt
>
>
> This is a problem when a user specifies ByteOrderedPartitioner with an odd-length initial token (like "0").

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1411) FBUtilities.hexToBytes() doesn't accommodate odd-length strings.

Posted by "Folke Behrens (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900743#action_12900743 ] 

Folke Behrens commented on CASSANDRA-1411:
------------------------------------------

Good ol' well-thought pragmatism? Why sanitize user input and adjust the token when you can hide errors by making core functions more flexible.

> FBUtilities.hexToBytes() doesn't accommodate odd-length strings.
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-1411
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1411
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.6.4
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7 beta 2
>
>         Attachments: v1-0001-FBUtilities.hexToBytes-doesn-t-handle-odd-length-strin.txt
>
>
> This is a problem when a user specifies ByteOrderedPartitioner with an odd-length initial token (like "0").

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1411) FBUtilities.hexToBytes() doesn't accommodate odd-length strings.

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-1411:
-------------------------------------

    Attachment: v1-0001-FBUtilities.hexToBytes-doesn-t-handle-odd-length-strin.txt

> FBUtilities.hexToBytes() doesn't accommodate odd-length strings.
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-1411
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1411
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.6.4
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>            Priority: Minor
>             Fix For: 0.7 beta 2
>
>         Attachments: v1-0001-FBUtilities.hexToBytes-doesn-t-handle-odd-length-strin.txt
>
>
> This is a problem when a user specifies ByteOrderedPartitioner with an odd-length initial token (like "0").

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.