You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Nikita Vetoshkin <ni...@gmail.com> on 2014/08/19 10:41:23 UTC

Review Request 24840: fix attributes docstring

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24840/
-----------------------------------------------------------

Review request for mesos.


Bugs: MESOS-1722
    https://issues.apache.org/jira/browse/MESOS-1722


Repository: mesos-git


Description
-------

fix attributes docstring


Diffs
-----

  src/slave/flags.hpp a4ddeb124f155ecdcfbd7a5b16f6ac51d9d0be37 

Diff: https://reviews.apache.org/r/24840/diff/


Testing
-------

built and manually checked help message


Thanks,

Nikita Vetoshkin

Re: Review Request 24840: fix attributes docstring

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24840/#review50987
-----------------------------------------------------------

Ship it!


Thanks Nikita. I'll get this committed shortly.

- Vinod Kone


On Aug. 19, 2014, 8:41 a.m., Nikita Vetoshkin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24840/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2014, 8:41 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1722
>     https://issues.apache.org/jira/browse/MESOS-1722
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> fix attributes docstring
> 
> 
> Diffs
> -----
> 
>   src/slave/flags.hpp a4ddeb124f155ecdcfbd7a5b16f6ac51d9d0be37 
> 
> Diff: https://reviews.apache.org/r/24840/diff/
> 
> 
> Testing
> -------
> 
> built and manually checked help message
> 
> 
> Thanks,
> 
> Nikita Vetoshkin
> 
>

Re: Review Request 24840: fix attributes docstring

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24840/#review50978
-----------------------------------------------------------


Patch looks great!

Reviews applied: [24840]

All tests passed.

- Mesos ReviewBot


On Aug. 19, 2014, 8:41 a.m., Nikita Vetoshkin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24840/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2014, 8:41 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-1722
>     https://issues.apache.org/jira/browse/MESOS-1722
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> fix attributes docstring
> 
> 
> Diffs
> -----
> 
>   src/slave/flags.hpp a4ddeb124f155ecdcfbd7a5b16f6ac51d9d0be37 
> 
> Diff: https://reviews.apache.org/r/24840/diff/
> 
> 
> Testing
> -------
> 
> built and manually checked help message
> 
> 
> Thanks,
> 
> Nikita Vetoshkin
> 
>