You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Chris M. Hostetter (Jira)" <ji...@apache.org> on 2020/06/05 16:58:00 UTC
[jira] [Assigned] (SOLR-14467) json.facet's relatedness() should
not cause server errors or nonsense results when combined with
allBuckets:true
[ https://issues.apache.org/jira/browse/SOLR-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris M. Hostetter reassigned SOLR-14467:
-----------------------------------------
Fix Version/s: 8.6
master (9.0)
Assignee: Chris M. Hostetter
Description:
While testing randomized permutations of json.facet params in combination with the {{relatedness()}} function it was discovered that:
* {{relatedness()}} would produce server errors in many situations when combined with {{allBuckets:true}}
* In situations where this combination of options was used an a server error did not happen, the computed values for the {{relatedness()}} function that would be put in the {{allBuckets}} bucket were meaningless
The end result of this jira was to modify {{relatedness()}} to skip computation for the {{allBuckets}} bucket
{panel:title=original description}
While working on randomized testing for SOLR-13132 i discovered a variety of different ways that JSON Faceting's "allBuckets" option can fail when combined with the "relatedness()" function.
I haven't found a trivial way to manual reproduce this, but i have been able to trigger the failures with a trivial patch to {{TestCloudJSONFacetSKG}} which i will attach.
Based on the nature of the failures it looks like it may have something to do with multiple segments of different sizes, and or resizing the SlotAccs ?
The relatedness() function doesn't have much (any?) existing tests in place that leverage "allBuckets" so this is probably a bug that has always existed -- it's possible it may be excessively cumbersome to fix and we might nee/wnat to just document that incompatibility and add some code to try and detect if the user combines these options and if so fail with a 400 error?
{panel}
was:
While working on randomized testing for SOLR-13132 i discovered a variety of different ways that JSON Faceting's "allBuckets" option can fail when combined with the "relatedness()" function.
I haven't found a trivial way to manual reproduce this, but i have been able to trigger the failures with a trivial patch to {{TestCloudJSONFacetSKG}} which i will attach.
Based on the nature of the failures it looks like it may have something to do with multiple segments of different sizes, and or resizing the SlotAccs ?
The relatedness() function doesn't have much (any?) existing tests in place that leverage "allBuckets" so this is probably a bug that has always existed -- it's possible it may be excessively cumbersome to fix and we might nee/wnat to just document that incompatibility and add some code to try and detect if the user combines these options and if so fail with a 400 error?
Summary: json.facet's relatedness() should not cause server errors or nonsense results when combined with allBuckets:true (was: inconsistent server errors combining relatedness() with allBuckets:true)
> json.facet's relatedness() should not cause server errors or nonsense results when combined with allBuckets:true
> ----------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-14467
> URL: https://issues.apache.org/jira/browse/SOLR-14467
> Project: Solr
> Issue Type: Bug
> Components: Facet Module
> Reporter: Chris M. Hostetter
> Assignee: Chris M. Hostetter
> Priority: Major
> Fix For: master (9.0), 8.6
>
> Attachments: SOLR-14467.patch, SOLR-14467.patch, SOLR-14467.patch, SOLR-14467.patch, SOLR-14467_allBuckets_refine.patch, SOLR-14467_test.patch, SOLR-14467_test.patch, beast.log.txt, beast2.log.txt
>
>
> While testing randomized permutations of json.facet params in combination with the {{relatedness()}} function it was discovered that:
> * {{relatedness()}} would produce server errors in many situations when combined with {{allBuckets:true}}
> * In situations where this combination of options was used an a server error did not happen, the computed values for the {{relatedness()}} function that would be put in the {{allBuckets}} bucket were meaningless
> The end result of this jira was to modify {{relatedness()}} to skip computation for the {{allBuckets}} bucket
> {panel:title=original description}
> While working on randomized testing for SOLR-13132 i discovered a variety of different ways that JSON Faceting's "allBuckets" option can fail when combined with the "relatedness()" function.
> I haven't found a trivial way to manual reproduce this, but i have been able to trigger the failures with a trivial patch to {{TestCloudJSONFacetSKG}} which i will attach.
> Based on the nature of the failures it looks like it may have something to do with multiple segments of different sizes, and or resizing the SlotAccs ?
> The relatedness() function doesn't have much (any?) existing tests in place that leverage "allBuckets" so this is probably a bug that has always existed -- it's possible it may be excessively cumbersome to fix and we might nee/wnat to just document that incompatibility and add some code to try and detect if the user combines these options and if so fail with a 400 error?
> {panel}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org