You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/29 23:09:58 UTC

[GitHub] [beam] TheNeuralBit opened a new issue, #22950: [Task]: Re-use BatchConverterTest for different implementations

TheNeuralBit opened a new issue, #22950:
URL: https://github.com/apache/beam/issues/22950

   ### What needs to happen?
   
   We have `BatchConverterTest` in `batch.py`, which is used to test the list and numpy implementations. As more `BatchConverter` implementations are added they will need to add tests that are almost identical to this one, with a few alterations:
   - The test data, currently handled with `parameterized_class`.
   - Possibly a custom equality check (e.g. `pd.testing.assert_frame_equal` for pandas)
   
   We should make it possible to re-use the tests in `BatchConverterTest` without copy-pasting it, as this will lead to fragmentation.
   
   ### Issue Priority
   
   Priority: 2
   
   ### Issue Component
   
   Component: dsl-dataframe


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org